Build rdr_image via action #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

prsurve wants to merge 11 commits into master from build_rdr_image_via_action

Contributor

prsurve commented Oct 15, 2025

No description provided.


          Build rdr_image via action

6eb4590

Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prsurve

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [prsurve]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

prsurve added the build_image label

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

prsurve removed the build_image label


          update dockerfile path

064ace1

prsurve added the build_image label

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

prsurve added force_build_image and removed build_image labels


          Add space

3358d42

prsurve added force_build_image and removed force_build_image labels


          fix build failure

b8ae65a

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

prsurve added force_build_image and removed force_build_image labels


          fix registry path

9f60ca5

prsurve added the force_build_image label

github-actions bot commented Oct 15, 2025

✅ Image Build Complete
The container image was built and pushed successfully for branch build_rdr_image_via_action
Label: force_build_image
🏷️ Image tags: pr-127 master

prsurve removed the force_build_image label


          Add more platforms

d35e405

prsurve added force_build_image and removed force_build_image labels


          update image tag

e7e8793

prsurve added the force_build_image label

github-actions bot commented Oct 15, 2025

✅ Image Build Complete
The container image was built and pushed successfully for branch build_rdr_image_via_action
Label: force_build_image
🏷️ Image tags: pr-127 master


          test

e3706bc

prsurve added force_build_image and removed force_build_image labels

github-actions bot removed the force_build_image label


          Final Change

b21a5d7

prsurve added the build_image label

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

github-actions bot commented Oct 15, 2025

✅ Image Build Complete
The container image was built and pushed successfully for branch build_rdr_image_via_action
Label: build_image
🏷️ Image tags: pr-127 master

github-actions bot removed the build_image label


          dont build image when skipped

b53876a

prsurve added the build_image label

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

github-actions bot commented Oct 15, 2025

✅ Image Build Complete
The container image was built and pushed successfully for branch build_rdr_image_via_action
Label: build_image
🏷️ Image tags: pr-127 master

github-actions bot removed the build_image label


          make it more clean

d0d1310

prsurve added the build_image label

github-actions bot commented Oct 15, 2025

⚠️ Build Skipped
No Dockerfile changes were detected in this PR.
Label: build_image

github-actions bot removed the build_image label

petr-balogh reviewed

View reviewed changes

.github/workflows/build_rdr_image.yaml

+                  # Run only when these labels are added
+                  if: |
+                    github.event.label.name == 'force_build_image' ||

Member

petr-balogh Oct 16, 2025

Why just not build new image on any new PR Merge and only when label added?

Contributor Author

prsurve Oct 24, 2025

We can do that i though of why to create images if there is no change in docker file or script

.github/workflows/build_rdr_image.yaml

+                        fetch-depth: 0  # Needed for diff detection
+                    # ------------------------------
+                    # 2️⃣ Detect Dockerfile Changes

Member

petr-balogh Oct 16, 2025

I don't think we should skip building the image if Dockerfile didn't change. There might be changes in other files we might want to copy to the image for example. So , I think it's better just always on any PR build the image if it cost us nothing. WDYT?

Contributor Author

prsurve Oct 24, 2025

sure will make the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels