Make changes to support running workloads in offline/Disonnected mode #128
Conversation
rdr/container_image/Dockerfile
Outdated
| WORKDIR arequal | ||
| RUN ./autogen.sh ; ./configure ; make ; make install | ||
| WORKDIR / | ||
| ADD https://raw.githubusercontent.com/red-hat-storage/ocs-workloads/master/rdr/busybox/scripts/simple_io_integrity_check.sh /mnt/simple_io_integrity_check.sh |
There was a problem hiding this comment.
I don't like an idea of using ADD from the master repository - which will aways require you to merge the change without possibility to test this first. I hope if the context for building of the image is root of the repository we can do something like:
COPY rdr/busybox/scripts/simple_io_integrity_check.sh /mnt/
COPY rdr/busybox/scripts/simple_io.sh /mnt/
Instead of using add from raw repo gitlab URL.
There was a problem hiding this comment.
ack will send a commet with this change
| RUN ./autogen.sh ; ./configure ; make ; make install | ||
| WORKDIR / | ||
| ADD https://raw.githubusercontent.com/red-hat-storage/ocs-workloads/master/rdr/busybox/scripts/simple_io_integrity_check.sh /mnt/simple_io_integrity_check.sh | ||
| RUN chmod +x /mnt/simple_io_integrity_check.sh |
There was a problem hiding this comment.
if we do set properly the permission on those files in repository - I think the permission will be carried on via COPY as well inside the image - so if my assumption is correct - you can remove those chmod +x RUN Commands
There was a problem hiding this comment.
will check and test it for now will keep as it is
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-balogh, prsurve The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
merging post GA |
|
/unhold |
openshift-merge-bot
bot
merged commit bc60df0
into
red-hat-storage:master
2 participants
Reason behind the pr:-
When we use the workload before this PR in offline mode, we cannot pull the script from GitHub. so we are building and updating container images which already have script buildin.