Skip to content

Conversation

@subhamkrai
Copy link
Contributor

@subhamkrai subhamkrai commented Oct 7, 2025

ci: add ci to test the commands

This commit add ci tests for the go commands,
adds golangci test and commitlint ci.

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Oct 7, 2025
@subhamkrai
Copy link
Contributor Author

/test all

@subhamkrai subhamkrai force-pushed the add-ci branch 2 times, most recently from 3a8f136 to 284a9b5 Compare October 7, 2025 09:20
@subhamkrai
Copy link
Contributor Author

/test all

@openshift-ci
Copy link

openshift-ci bot commented Oct 7, 2025

@subhamkrai: No presubmit jobs available for red-hat-storage/odf-cli@main

Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai subhamkrai marked this pull request as ready for review October 7, 2025 09:44
@subhamkrai subhamkrai changed the title ci: add ci to test the commands wip: ci: add ci to test the commands Oct 7, 2025
@subhamkrai
Copy link
Contributor Author

/test all

@subhamkrai subhamkrai marked this pull request as draft October 7, 2025 10:08
@subhamkrai subhamkrai marked this pull request as ready for review October 7, 2025 15:26
@subhamkrai subhamkrai changed the title wip: ci: add ci to test the commands ci: add ci to test the commands Oct 7, 2025
@subhamkrai subhamkrai marked this pull request as draft October 13, 2025 10:44
@malayparida2000
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2025

@malayparida2000: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@subhamkrai
Copy link
Contributor Author

@travisn ^

Copy link
Contributor

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of the new CI tests are failing?

@subhamkrai subhamkrai force-pushed the add-ci branch 3 times, most recently from 8c2ba69 to 73d01f1 Compare December 17, 2025 12:10
This commit add ci tests for the go commands,
adds golangci test and commitlint ci.

Signed-off-by: subhamkrai <[email protected]>
@@ -0,0 +1,29 @@
name: Commitlint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest let's not have the commitlint in this repo, I don't think we need it for the downstream.

# actions/setup-go already handles caching
skip-cache: true

govulncheck:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not passing yet, let's remove it from this PR and have a follow-up PR. It's better to keep green CI when introducing new checks.

with:
fetch-depth: 0

- name: odf-cli test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing. Either let's find the fix, or save for a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants