-
Notifications
You must be signed in to change notification settings - Fork 13
ci: add ci to test the commands #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
3a8f136 to
284a9b5
Compare
|
/test all |
|
@subhamkrai: No presubmit jobs available for red-hat-storage/odf-cli@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
/lgtm |
|
@malayparida2000: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
64f31bb to
e7e3b0b
Compare
a0cb44e to
c9c737e
Compare
0535bf2 to
d68c1cd
Compare
|
@travisn ^ |
travisn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of the new CI tests are failing?
8c2ba69 to
73d01f1
Compare
This commit add ci tests for the go commands, adds golangci test and commitlint ci. Signed-off-by: subhamkrai <[email protected]>
| @@ -0,0 +1,29 @@ | |||
| name: Commitlint | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest let's not have the commitlint in this repo, I don't think we need it for the downstream.
| # actions/setup-go already handles caching | ||
| skip-cache: true | ||
|
|
||
| govulncheck: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is not passing yet, let's remove it from this PR and have a follow-up PR. It's better to keep green CI when introducing new checks.
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: odf-cli test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing. Either let's find the fix, or save for a follow-up PR.
ci: add ci to test the commands