Add provision to recipe parameters while enrolling applicaiton

[TimothyAsirJeyasing]

https://issues.redhat.com/browse/DFBUGS-857

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimothyAsirJeyasing
Once this PR has been reviewed and has the lgtm label, please assign bipuladh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TimothyAsirJeyasing]

[GowthamShanmugam]

Is this design discussed with DR team? And how the user will know how to input string[] as a value?

[TimothyAsirJeyasing]

[GowthamShanmugam]

@raghavendra-talur, as per this implementation, UI passes one value per key, is that ok, or will it create any problem?

[raghavendra-talur]

@raghavendra-talur, as per this implementation, UI passes one value per key, is that ok, or will it create any problem?

The params type is RecipeParameters map[string][]string
https://github.com/RamenDR/ramen/blob/734cba31cf6001cd4dd614b38b8ab0bdef0d9dd1/api/v1alpha1/volumereplicationgroup_types.go#L138

It needs to match this. We can ask the users to provide the list in comma separated way and put the values in the [].

[TimothyAsirJeyasing]

[openshift-ci]

@TimothyAsirJeyasing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/odf-console-e2e-aws	1f1025c	link	true	/test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[GowthamShanmugam]

Suggested change

	export const formatRecipeParametersForDisplay = (
	params: Record<string, string[]>
	): string => {
	return Object.entries(params || {})
	.map(([key, values]) => `${key}: ${values.join(', ')}`)
	.join('; ');
	};

[GowthamShanmugam]

It is for display only, let's keep it inside the review-step.tsx file.

[GowthamShanmugam]

Here,
The parameters are already comma-separated strings,
convertToRecipeParameters is converting the parameter into a list, and formatRecipeParametersForDisplay is again converting it back to comma comma-separated string.

This looks redundant, I think only the whitespace trimming logic has to be common between these two functions.