Skip to content

Add provision to recipe parameters while enrolling applicaiton #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Add provision to recipe parameters while enrolling applicaiton #1934

merged 1 commit into from
Jun 3, 2025

Conversation

TimothyAsirJeyasing
Copy link
Contributor

@TimothyAsirJeyasing
Copy link
Contributor Author

Screenshot from 2025-04-02 17-43-27
Screenshot from 2025-04-02 13-47-44

GowthamShanmugam
GowthamShanmugam reviewed Apr 3, 2025
View reviewed changes
GowthamShanmugam
GowthamShanmugam reviewed Apr 3, 2025
View reviewed changes
GowthamShanmugam
GowthamShanmugam reviewed Apr 3, 2025
View reviewed changes
@GowthamShanmugam
Copy link
Contributor

Screenshot from 2025-04-02 17-43-27 Screenshot from 2025-04-02 13-47-44

Is this design discussed with DR team? And how the user will know how to input string[] as a value?

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch 2 times, most recently from 7de232b to ea6b330 Compare April 22, 2025 08:27
@TimothyAsirJeyasing
Copy link
Contributor Author

image

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch 2 times, most recently from f7f2655 to 149bd07 Compare April 28, 2025 15:59
@GowthamShanmugam
Copy link
Contributor

Screenshot from 2025-04-02 17-43-27 Screenshot from 2025-04-02 13-47-44

@raghavendra-talur, as per this implementation, UI passes one value per key, is that ok, or will it create any problem?

@raghavendra-talur
Copy link

raghavendra-talur commented Apr 29, 2025 •
edited
Loading

@raghavendra-talur, as per this implementation, UI passes one value per key, is that ok, or will it create any problem?

The params type is RecipeParameters map[string][]string
https://github.com/RamenDR/ramen/blob/734cba31cf6001cd4dd614b38b8ab0bdef0d9dd1/api/v1alpha1/volumereplicationgroup_types.go#L138

It needs to match this. We can ask the users to provide the list in comma separated way and put the values in the [].

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch from 149bd07 to 1f1025c Compare May 6, 2025 09:30
@TimothyAsirJeyasing
Copy link
Contributor Author

TimothyAsirJeyasing commented May 6, 2025 •
edited
Loading

image
image

@SanjalKatiyar
Copy link
Collaborator

@TimothyAsirJeyasing can you plz update the PR ??

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch from 1f1025c to e7473b8 Compare May 30, 2025 08:09
@TimothyAsirJeyasing
Copy link
Contributor Author

Screenshot 2025-05-30 at 1 29 48 PM Screenshot 2025-05-30 at 1 30 05 PM Screenshot 2025-05-30 at 1 30 38 PM

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch from e7473b8 to 9e62b14 Compare June 2, 2025 14:13
@TimothyAsirJeyasing
Copy link
Contributor Author

Screenshot 2025-06-02 at 7 29 47 PM Screenshot 2025-06-02 at 7 30 06 PM Screenshot 2025-06-02 at 7 30 36 PM

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the add-config-param-to-recipe branch from 9e62b14 to 7d283fa Compare June 3, 2025 13:03
@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@SanjalKatiyar
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SanjalKatiyar, TimothyAsirJeyasing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 3, 2025
@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit 9584920 into red-hat-storage:master Jun 3, 2025
5 checks passed
@SanjalKatiyar
Copy link
Collaborator

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@SanjalKatiyar: new pull request created: #2106

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavendra-talur raghavendra-talur raghavendra-talur left review comments

@alfonsomthd alfonsomthd alfonsomthd left review comments

@GowthamShanmugam GowthamShanmugam GowthamShanmugam left review comments

@SanjalKatiyar SanjalKatiyar SanjalKatiyar left review comments

Assignees

@SanjalKatiyar SanjalKatiyar

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TimothyAsirJeyasing @GowthamShanmugam @raghavendra-talur @SanjalKatiyar @openshift-cherrypick-robot @alfonsomthd