Skip to content

[release-4.19] DFBUGS-2248: Introduces new flag for detection of internal mode #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #2053

/assign SanjalKatiyar

@bipuladh bipuladh changed the title [release-4.19] Introduces new flag for detection of internal mode [release-4.19] DFBUGS-2248: Introduces new flag for detection of internal mode Apr 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Apr 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2025

@openshift-cherrypick-robot: This pull request references [Jira Issue DFBUGS-2248](https://issues.redhat.com//browse/DFBUGS-2248), which is invalid:

  • expected the bug to target the "odf-4.19" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This is an automated cherry-pick of #2053

/assign SanjalKatiyar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bipuladh
Copy link
Contributor

/test odf-console-e2e-aws

@bipuladh
Copy link
Contributor

/jira refresh

@bipuladh
Copy link
Contributor

/test odf-console-e2e-aws

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting label Apr 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2025

@bipuladh: This pull request references [Jira Issue DFBUGS-2248](https://issues.redhat.com//browse/DFBUGS-2248), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.19) matches configured target version for branch (odf-4.19)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting label Apr 30, 2025
@bipuladh
Copy link
Contributor

/test odf-console-e2e-aws

1 similar comment
@bipuladh
Copy link
Contributor

/test odf-console-e2e-aws

A flag is introduced by client plugin to disable itself
Flag is based on the present of successfully loaded odf-console plugin

Signed-off-by: Bipul Adhikari <[email protected]>
@bipuladh bipuladh force-pushed the cherry-pick-2053-to-release-4.19 branch from 7f87f70 to c2aa08b Compare April 30, 2025 12:09
@SanjalKatiyar
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 5, 2025
Copy link
Contributor

openshift-ci bot commented May 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, SanjalKatiyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 5, 2025
@bipuladh
Copy link
Contributor

bipuladh commented May 7, 2025

/override ci/prow/odf-console-e2e-aws

Copy link
Contributor

openshift-ci bot commented May 7, 2025

@bipuladh: Overrode contexts on behalf of bipuladh: ci/prow/odf-console-e2e-aws

In response to this:

/override ci/prow/odf-console-e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 457d3aa into red-hat-storage:release-4.19 May 7, 2025
5 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2025

@openshift-cherrypick-robot: [Jira Issue DFBUGS-2248](https://issues.redhat.com//browse/DFBUGS-2248): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-2248](https://issues.redhat.com//browse/DFBUGS-2248) has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #2053

/assign SanjalKatiyar

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants