-
Notifications
You must be signed in to change notification settings - Fork 35
DFBUGS-2822: [release-4.19] Backport dfbugs 4286 fix dr status vms #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.19
Are you sure you want to change the base?
Conversation
|
@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is valid. The bug has been moved to the POST state. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822). The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is valid. 2 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test images |
f4fed72 to
03452e1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test odf-console-e2e-aws |
1 similar comment
|
/test odf-console-e2e-aws |
|
as discussed earlier, u need PR for compatibility branch as well... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ODF_RESOURCE_TYPE_LABEL from mco/constants/common.ts as well as any other remaining places...
u r already doing unrelated changes in this PR, atleast make sure all such instances of that change has been handled... we are setting ODF_RESOURCE_TYPE_LABEL annotation when creating DRPC, which is not required if u are not polling based on that...
|
LGTM other than couple of comments: |
…very' for VMs Fixes: https://issues.redhat.com/browse/DFBUGS-2823 https://issues.redhat.com/browse/DFBUGS-2822 https://issues.redhat.com/browse/DFBUGS-3821 Manually cherry picked from red-hat-storage#2325 Signed-off-by: SanjalKatiyar <[email protected]> Signed-off-by: Timothy Asir Jeyasingh <[email protected]>
03452e1 to
0a4dbba
Compare
|
@TimothyAsirJeyasing: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |



Fixes:
https://issues.redhat.com/browse/DFBUGS-2822
https://issues.redhat.com/browse/DFBUGS-3821
https://issues.redhat.com/browse/DFBUGS-2823
Manually cherry picked from: #2325