Skip to content

Conversation

@TimothyAsirJeyasing
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

Fixes:
https://issues.redhat.com/browse/DFBUGS-2822
https://issues.redhat.com/browse/DFBUGS-3821
https://issues.redhat.com/browse/DFBUGS-2823

Manually cherry picked from: #2325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822). The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes:
https://issues.redhat.com/browse/DFBUGS-2822
https://issues.redhat.com/browse/DFBUGS-3821
https://issues.redhat.com/browse/DFBUGS-2823

Manually cherry picked from: #2325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

Fixes:
https://issues.redhat.com/browse/DFBUGS-2822
https://issues.redhat.com/browse/DFBUGS-3821
https://issues.redhat.com/browse/DFBUGS-2823

Manually cherry picked from: #2325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TimothyAsirJeyasing TimothyAsirJeyasing changed the base branch from master to release-4.19 December 10, 2025 16:16
@openshift-ci-robot openshift-ci-robot added jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting and removed jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 10, 2025

@TimothyAsirJeyasing: This pull request references [Jira Issue DFBUGS-2822](https://issues.redhat.com//browse/DFBUGS-2822), which is invalid:

  • expected the bug to target the "odf-4.19.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Fixes:
https://issues.redhat.com/browse/DFBUGS-2822
https://issues.redhat.com/browse/DFBUGS-3821
https://issues.redhat.com/browse/DFBUGS-2823

Manually cherry picked from: #2325

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TimothyAsirJeyasing TimothyAsirJeyasing changed the title DFBUGS-2822: [release-4.19] Backport dfbugs 4286 fix dr status vms release 4.19 DFBUGS-2822: [release-4.19] Backport dfbugs 4286 fix dr status vms Dec 10, 2025
@TimothyAsirJeyasing
Copy link
Contributor Author

/test images

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the backport-DFBUGS-4286-fix-dr-status-vms-release-4.19 branch from f4fed72 to 03452e1 Compare December 12, 2025 21:23
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TimothyAsirJeyasing
Once this PR has been reviewed and has the lgtm label, please assign sanjalkatiyar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TimothyAsirJeyasing
Copy link
Contributor Author

Image Screenshot 2025-12-13 at 12 21 06 AM Image 2

@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

1 similar comment
@TimothyAsirJeyasing
Copy link
Contributor Author

/test odf-console-e2e-aws

@SanjalKatiyar
Copy link
Collaborator

as discussed earlier, u need PR for compatibility branch as well...

Copy link
Collaborator

@SanjalKatiyar SanjalKatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ODF_RESOURCE_TYPE_LABEL from mco/constants/common.ts as well as any other remaining places...
u r already doing unrelated changes in this PR, atleast make sure all such instances of that change has been handled... we are setting ODF_RESOURCE_TYPE_LABEL annotation when creating DRPC, which is not required if u are not polling based on that...

@SanjalKatiyar
Copy link
Collaborator

LGTM other than couple of comments:
#2430 (comment) and #2430 (review)

@TimothyAsirJeyasing TimothyAsirJeyasing force-pushed the backport-DFBUGS-4286-fix-dr-status-vms-release-4.19 branch from 03452e1 to 0a4dbba Compare December 15, 2025 16:41
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@TimothyAsirJeyasing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-console-e2e-aws 0a4dbba link true /test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants