Skip to content

DFBUGS-4760: [release-4.19] remove protected app annotation on DR unassignment #2432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vbnrh wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

DFBUGS-4760: [release-4.19] remove protected app annotation on DR unassignment #2432

vbnrh wants to merge 1 commit into from

Conversation

@vbnrh
Copy link
Member

@vbnrh vbnrh commented Dec 11, 2025

  • Add removeExperimentalAnnotationPromises to remove PROTECTED_APP_ANNOTATION from placements in batch operations with parallel placement fetching for performance
  • Convert unAssignPromisesForManaged to async function enforcing sequential execution: add PVC protection annotations first, then delete DRPCs after PVCs are protected
  • Update unAssignPromises to remove placement annotations before proceeding with PVC protection and DRPC deletion
  • Add experimentalAnnotationRemovalPatchPromise to single app removal modal to remove annotation from placement via spec.placementRef
  • Convert RemoveDisasterRecoveryModal onRemove handler to async/await pattern for proper sequential execution

Execution order is now guaranteed:

  1. Remove PROTECTED_APP_ANNOTATION from placements
  2. Add PVC protection annotations to DRPCs
  3. Delete DRPC resources

This ensures PVCs are protected before DRPC deletion and placements are unprotected before cleanup begins.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting labels Dec 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025 •
edited by openshift-ci bot
Loading

@vbnrh: This pull request references [Jira Issue DFBUGS-4760](https://issues.redhat.com//browse/DFBUGS-4760), which is invalid:

  • expected the bug to target the "odf-4.19.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

  • Add removeExperimentalAnnotationPromises to remove PROTECTED_APP_ANNOTATION from placements in batch operations with parallel placement fetching for performance
  • Convert unAssignPromisesForManaged to async function enforcing sequential execution: add PVC protection annotations first, then delete DRPCs after PVCs are protected
  • Update unAssignPromises to remove placement annotations before proceeding with PVC protection and DRPC deletion
  • Add experimentalAnnotationRemovalPatchPromise to single app removal modal to remove annotation from placement via spec.placementRef
  • Convert RemoveDisasterRecoveryModal onRemove handler to async/await pattern for proper sequential execution

Execution order is now guaranteed:

  1. Remove PROTECTED_APP_ANNOTATION from placements
  2. Add PVC protection annotations to DRPCs
  3. Delete DRPC resources

This ensures PVCs are protected before DRPC deletion and placements are unprotected before cleanup begins.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vbnrh
Once this PR has been reviewed and has the lgtm label, please assign gowthamshanmugam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vbnrh
remove protected app annotation on DR unassignment
bcaa18b 
    Changes:
    - Add removeExperimentalAnnotationPromises to remove
      PROTECTED_APP_ANNOTATION from placements in batch operations with
      parallel placement fetching for performance
    - Convert unAssignPromisesForManaged to async function enforcing
      sequential execution: add PVC protection annotations first, then
      delete DRPCs after PVCs are protected
    - Update unAssignPromises to remove placement annotations before
      proceeding with PVC protection and DRPC deletion
    - Add experimentalAnnotationRemovalPatchPromise to single app removal
      modal to remove annotation from placement via spec.placementRef
    - Convert RemoveDisasterRecoveryModal onRemove handler to async/await
      pattern for proper sequential execution

    Execution order is now guaranteed:
    1. Remove PROTECTED_APP_ANNOTATION from placements
    2. Add PVC protection annotations to DRPCs
    3. Delete DRPC resources

Signed-off-by: vbadrina <[email protected]>
@vbnrh vbnrh force-pushed the remove-protected-app-annotation branch from 0034a3c to bcaa18b Compare December 11, 2025 06:40
@vbnrh
Copy link
Member Author

vbnrh commented Dec 11, 2025

/cherry-pick release-4.19-compatibility

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 11, 2025

@vbnrh: once the present PR merges, I will cherry-pick it on top of release-4.19-compatibility in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19-compatibility

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vbnrh
Copy link
Member Author

vbnrh commented Dec 11, 2025

/test odf-console-e2e-aws

@vbnrh
Copy link
Member Author

vbnrh commented Dec 11, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025 •
edited by openshift-ci bot
Loading

@vbnrh: This pull request references [Jira Issue DFBUGS-4760](https://issues.redhat.com//browse/DFBUGS-4760), which is invalid:

  • expected the bug to target either version "odf-4.19.9." or "openshift-odf-4.19.9.", but it targets "odf-4.19.7" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vbnrh
Copy link
Member Author

vbnrh commented Dec 11, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025 •
edited by openshift-ci bot
Loading

@vbnrh: This pull request references [Jira Issue DFBUGS-4760](https://issues.redhat.com//browse/DFBUGS-4760), which is invalid:

  • expected the bug to target the "odf-4.19.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vbnrh
Copy link
Member Author

vbnrh commented Dec 11, 2025

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2025 •
edited by openshift-ci bot
Loading

@vbnrh: This pull request references [Jira Issue DFBUGS-4760](https://issues.redhat.com//browse/DFBUGS-4760), which is invalid:

  • expected the bug to target the "odf-4.19.9" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

@vbnrh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-console-e2e-aws bcaa18b link true /test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Dec 15, 2025

u need PR for compatibility branch as well...

@SanjalKatiyar
Copy link
Collaborator

SanjalKatiyar commented Dec 15, 2025

LGTM other than: #2432 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

jira/invalid-bug Indicates that the referenced jira bug is invalid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vbnrh @openshift-ci-robot @openshift-cherrypick-robot @SanjalKatiyar