-
Notifications
You must be signed in to change notification settings - Fork 35
Delete all user policies before deleting the user IAM #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Delete all user policies before deleting the user IAM #2443
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: NIKHITHAVADDEMPUDI The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid. The bug has been moved to the POST state. 2 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid. 2 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid. 2 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retitle Delete all user policies before deleting the user IAM |
|
@NIKHITHAVADDEMPUDI: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@NIKHITHAVADDEMPUDI: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
https://issues.redhat.com/browse/DFBUGS-4869
Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion
Fix :
with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html
Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx
since inline policy is added in create user flow , and the deletion works fine with the fix
Screen.Recording.2025-12-19.at.2.52.40.PM.mov