Skip to content

Conversation

@NIKHITHAVADDEMPUDI
Copy link
Contributor

@NIKHITHAVADDEMPUDI NIKHITHAVADDEMPUDI commented Dec 19, 2025

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix :

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NIKHITHAVADDEMPUDI
Once this PR has been reviewed and has the lgtm label, please assign alfonsomthd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 19, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

Details

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleaup policies function in and using this function before deleting a user , and also in clean up of create user form
since inline policy is added in create user flow , and the deletion works fine with the fix

Uploading Screen Recording 2025-12-19 at 2.52.40 PM.mov…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid. The bug has been moved to the POST state.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleaup policies function in and using this function before deleting a user , and also in clean up of create user form
since inline policy is added in create user flow , and the deletion works fine with the fix

Uploading Screen Recording 2025-12-19 at 2.52.40 PM.mov…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

Details

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 19, 2025

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

Details

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix :

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: PrasadDesala.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@NIKHITHAVADDEMPUDI: This pull request references [Jira Issue DFBUGS-4869](https://issues.redhat.com//browse/DFBUGS-4869), which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @PrasadDesala

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix :

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SanjalKatiyar
Copy link
Collaborator

/retitle Delete all user policies before deleting the user IAM

@openshift-ci openshift-ci bot changed the title DFBUGS-4869: Delete all user policies before deleting the user IAM Delete all user policies before deleting the user IAM Dec 19, 2025
@openshift-ci-robot openshift-ci-robot removed jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Dec 19, 2025
@openshift-ci-robot
Copy link

@NIKHITHAVADDEMPUDI: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

https://issues.redhat.com/browse/DFBUGS-4869

Currently we are only deleteing the s3 policy that is added while creation.
We need to cleanup all the user policies, before user deletion

Fix :

with reference from the type of policies from the sites below, i am listing all inline and customer managed policies and deleting them.
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_manage-delete-api.html
and
https://docs.aws.amazon.com/IAM/latest/UserGuide/access_policies_managed-vs-inline.html

Added a cleanup policies function in packages/odf/utils/s3-iam.ts and using this function before deleting a user in packages/odf/modals/s3-iam/DeleteIamUserModal.tsx , and also in clean up flow of create user form before deleting a user in packages/odf/components/s3-iam/create-user/CreateUserForm.tsx

since inline policy is added in create user flow , and the deletion works fine with the fix

Screen.Recording.2025-12-19.at.2.52.40.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 19, 2025

@NIKHITHAVADDEMPUDI: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/odf-console-e2e-aws 56aac7c link true /test odf-console-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants