Skip mon-ip validation for cluster network CIDR#2701
Skip mon-ip validation for cluster network CIDR#2701TimothyAsirJeyasing wants to merge 1 commit intored-hat-storage:masterfrom
Conversation
Public network uses network.rook.io/mon-ip for mon placement; cluster network CIDR does not require mon-ip checks per storage team guidance. - nic: validate cluster CIDR format only; keep mon-ip checks for public - footer: require mon-ip and in-CIDR only when public CIDR is selected Signed-off-by: Timothy Asir Jeyasingh <tim.gluster@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TimothyAsirJeyasing The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
validating only public network, it will not validate for cluster network even though we give some random ip for the client network it does not do mon ip validation it does only the format check |
|
@TimothyAsirJeyasing: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test odf-console-e2e-aws |
1 participant
https://redhat.atlassian.net/browse/DFBUGS-5756
The initial requirement was to validate both the public network and the cluster network. However, based on later discussions, it was clarified that the public network uses network.rook.io/mon-ip for MON placement, while the cluster network CIDR does not require MON IP checks, as per guidance from the storage team.
Therefore, this PR removes validation for the cluster network MON IP and validates only the cluster network CIDR format.