Syncing latest changes from upstream main for ramen #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces changes to disown PVC resources when a VRG is deleted, particularly in scenarios where the DR is disabled. The motivation behind this adjustment is to give back the management of the PVC lifecycle to OCM. Upon disabling DR, the VRG now iterates through all volsync-managed PVCs. It removes VRG ownership from these PVCs and reinstates OCM annotations. This ensures that PVCs are not prematurely garbage collected upon VRG deletion. In order for that to work, a new annotation needs to be added to the VRG to indicate that the PVCs should be disowned upon DR disabling drplacementcontrol.ramendr.openshift.io/do-not-delete-pvc: "true" Signed-off-by: Benamar Mekhissi <[email protected]>
Signed-off-by: Benamar Mekhissi <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: df-build-team The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream main branch