Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for ramen #182

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

This commit introduces changes to disown PVC resources when a VRG is deleted,
particularly in scenarios where the DR is disabled. The motivation behind this
adjustment is to give back the management of the PVC lifecycle to OCM.

Upon disabling DR, the VRG now iterates through all volsync-managed PVCs.
It removes VRG ownership from these PVCs and reinstates OCM annotations.
This ensures that PVCs are not prematurely garbage collected upon VRG deletion.

In order for that to work, a new annotation needs to be added to the VRG to
indicate that the PVCs should be disowned upon DR disabling
drplacementcontrol.ramendr.openshift.io/do-not-delete-pvc: "true"

Signed-off-by: Benamar Mekhissi <[email protected]>
@df-build-team df-build-team requested a review from a team February 6, 2024 08:06
Copy link

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR ShyamsundarR merged commit 2dcfa67 into main Feb 6, 2024
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants