Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syncing latest changes from upstream main for ramen #184

Merged
merged 4 commits into from
Feb 7, 2024

Conversation

df-build-team
Copy link

PR containing the latest commits from upstream main branch

raghavendra-talur and others added 4 commits February 6, 2024 10:19
This commit changes the name and the values that we log with. The logger
is created with the name of the controller. The logger also adds the
values of customresource, its UID and the version. This makes it very
easy to filter out the log messages based on those attributes
incrementally, thereby allowing one to look at the reconcile logs at the
the lowest granularity. The reconcile exit also logs the time spent for
reconcile.

Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Elena Gershkovich <[email protected]>
@df-build-team df-build-team requested a review from a team February 7, 2024 08:05
Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: df-build-team

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ShyamsundarR ShyamsundarR merged commit d428ff2 into main Feb 7, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants