Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2247518: refactor set-metrics #186

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Feb 8, 2024

this refactoring helps to set metrics even though
one of the cluster is down, at this time,the metrics value is set as 0 and alerts are fired.

Signed-off-by: rakeshgm [email protected]
(cherry picked from commit 34891bf)

this refactoring helps to set metrics even though
one of the cluster is down, at this time,the metrics
value is set as 0 and alerts are fired.

Signed-off-by: rakeshgm <[email protected]>
(cherry picked from commit 34891bf)
Copy link

openshift-ci bot commented Feb 8, 2024

@rakeshgm: This pull request references Bugzilla bug 2247518, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

Bug 2247518: refactor set-metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm label Feb 8, 2024
@ShyamsundarR ShyamsundarR merged commit 42fe9d7 into red-hat-storage:release-4.15 Feb 8, 2024
12 of 13 checks passed
Copy link

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rakeshgm, ShyamsundarR

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Feb 8, 2024

@rakeshgm: All pull requests linked via external trackers have merged:

Bugzilla bug 2247518 has been moved to the MODIFIED state.

In response to this:

Bug 2247518: refactor set-metrics

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants