Skip to content

Cancel running job #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Cancel running job #344

merged 5 commits into from
Feb 13, 2025

Conversation

lm-sec
Copy link
Collaborator

@lm-sec lm-sec commented Feb 9, 2025

Cancels a running job from the UI. Available in 3 locations:

Launch job

image

Job executions

image

Job execution details

image

After termination:

image

…ome cleanup to do. I also want to add the option from the execution list, it could be nice
…ls pages so that you can stop a job from anywhere it is relevant
@lm-sec lm-sec requested a review from Aboisier February 9, 2025 18:21
@lm-sec lm-sec self-assigned this Feb 9, 2025
Copy link
Collaborator Author

@lm-sec lm-sec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La nouvelle queue pourrait obliger de wipe kafka pour que le provisionning roule. Si on wipe Kafka, il faudrait également aller sync la cache dans le UI pour que les jobs qui sont juste locale (pas sur un repo) fonctionnent.

Copy link
Collaborator

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De la belle ouvrage ça! Ça va être vraiment satisfaisant de pouvoir stopper une job manuellement!

Ce srait intéressant d'ajouter un log indiquant genre "Manual stop requested by Jean-Guy Tremblay"

@Aboisier Aboisier merged commit 6d328b9 into main Feb 13, 2025
6 checks passed
@Aboisier Aboisier deleted the feature/cancel_running_job branch February 13, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants