Add warning message for CI check failures#229
Closed
thepetk wants to merge 2 commits into
Closed
Conversation
thepetk
requested review from
JslYoon,
gabemontero,
johnmcollier and
michael-valdron
as code owners
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I'm adding an error message in the ci test script, just to make it more clear that PRs coming from forks will need to have set secrets on the fork itself (by following the Testing.md file). There might be another way to handle this, however I do feel more comfortable keeping it like this (mostly from security perspective).
Which issue(s) does this PR fix
N/A
How to test changes / Special notes to the reviewer
Just an error message, if the CI passes we're good.