Repository navigation
chore(deps): update k8s.io/kube-openapi digest to ca3452a #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,6 @@ | ||
| module github.com/redhat-appstudio/dora-metrics | ||
|
|
||
| go 1.26.0 | ||
|
|
||
| toolchain go1.26.3 | ||
| go 1.27.0 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] api-contract The go directive changed from Suggested fix: Either (a) update the Dockerfile to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] api-contract The go directive changed from go 1.25.0 (with toolchain go1.26.3) to go 1.27.0 (with no toolchain directive). This raises the minimum required Go version to 1.27.0. However, the Dockerfile (line 2) uses golang:1.26-alpine and the CI workflow .github/workflows/tests.yml (lines 21 and 61) uses go-version: '1.26' for both lint and test jobs. Neither is updated in this PR. With GOTOOLCHAIN=auto (the default since Go 1.21), Go 1.26 would attempt to auto-download Go 1.27 at build time, which is fragile in CI and container build environments (depends on network access, download server availability, and adds latency). If GOTOOLCHAIN=local is set or auto-download fails, builds will fail outright with a version mismatch error. This is a scope escalation beyond a simple digest update -- the PR title says 'update k8s.io/kube-openapi digest' but the Go minimum version jumps two minor releases and the toolchain directive is dropped entirely. Suggested fix: Either (a) update the Dockerfile to golang:1.27-alpine and the CI workflow to go-version: '1.27' in this PR, or (b) keep the go 1.25.0 / toolchain go1.26.3 pair and find a version of kube-openapi that does not require Go 1.27. If Go 1.27 is intentional, the Dockerfile and CI must be updated in the same PR to avoid broken builds on main. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] api-contract The go directive changed from go 1.25.0 (with toolchain go1.26.3) to go 1.27.0 (with no toolchain directive). This raises the minimum required Go version to 1.27.0. However, the Dockerfile (line 2) uses golang:1.26-alpine and the CI workflow .github/workflows/tests.yml (lines 21 and 61) uses go-version: 1.26 for both lint and test jobs. Neither is updated in this PR. With GOTOOLCHAIN=auto (the default since Go 1.21), Go 1.26 would attempt to auto-download Go 1.27 at build time, which is fragile in CI and container build environments. If GOTOOLCHAIN=local is set or auto-download fails, builds will fail outright with a version mismatch error. Suggested fix: Either (a) update the Dockerfile to golang:1.27-alpine and the CI workflow to go-version: 1.27 in this PR, or (b) keep the go 1.25.0 / toolchain go1.26.3 pair and find a version of kube-openapi that does not require Go 1.27. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [high] api-contract The go directive changed from go 1.26.0 (with toolchain go1.26.3) to go 1.27.0 (with no toolchain directive). This raises the minimum required Go version to 1.27.0. However, the Dockerfile (line 2) uses golang:1.26-alpine and the CI workflow .github/workflows/tests.yml (lines 21 and 61) uses go-version 1.26 for both lint and test jobs. Neither is updated in this PR. With GOTOOLCHAIN=auto (the default since Go 1.21), Go 1.26 would attempt to auto-download Go 1.27 at build time, which is fragile in CI and container build environments. If GOTOOLCHAIN=local is set or auto-download fails, builds will fail outright with a version mismatch error. The toolchain directive is also dropped entirely, removing the previously explicit toolchain pinning. Suggested fix: Either (a) update the Dockerfile to golang:1.27-alpine and the CI workflow to go-version 1.27 in this PR, or (b) keep the go 1.26.0 / toolchain go1.26.3 pair and find a version of kube-openapi that does not require Go 1.27. If Go 1.27 is intentional, the Dockerfile and CI must be updated in the same PR to avoid broken builds on main. |
||
|
|
||
| require ( | ||
| github.com/argoproj/argo-cd/v2 v2.14.21 | ||
|
|
@@ -11,7 +9,7 @@ require ( | |
| github.com/google/go-github/v53 v53.2.0 | ||
| github.com/joho/godotenv v1.5.1 | ||
| github.com/redis/go-redis/v9 v9.22.0 | ||
| github.com/stretchr/testify v1.12.0 | ||
| github.com/stretchr/testify v1.12.1 | ||
| github.com/toon-format/toon-go v0.0.0-20251202084852-7ca0e27c4e8c | ||
| go.uber.org/zap v1.28.0 | ||
| golang.org/x/oauth2 v0.36.0 | ||
|
|
@@ -46,7 +44,6 @@ require ( | |
| github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
| github.com/distribution/reference v0.6.0 // indirect | ||
| github.com/dlclark/regexp2 v1.11.5 // indirect | ||
| github.com/emicklei/go-restful/v3 v3.13.0 // indirect | ||
| github.com/emirpasic/gods v1.18.1 // indirect | ||
| github.com/evanphx/json-patch v5.9.11+incompatible // indirect | ||
| github.com/exponent-io/jsonpath v0.0.0-20151013193312-d6023ce2651d // indirect | ||
|
|
@@ -58,27 +55,19 @@ require ( | |
| github.com/go-git/go-git/v5 v5.19.2 // indirect | ||
| github.com/go-logr/logr v1.4.3 // indirect | ||
| github.com/go-openapi/jsonpointer v1.0.1 // indirect | ||
| github.com/go-openapi/jsonreference v0.21.6 // indirect | ||
| github.com/go-openapi/swag v0.29.2 // indirect | ||
| github.com/go-openapi/swag/cmdutils v0.29.2 // indirect | ||
| github.com/go-openapi/jsonreference v1.0.0 // indirect | ||
| github.com/go-openapi/swag/conv v0.29.2 // indirect | ||
| github.com/go-openapi/swag/fileutils v0.29.2 // indirect | ||
| github.com/go-openapi/swag/jsonutils v0.29.2 // indirect | ||
| github.com/go-openapi/swag/loading v0.29.2 // indirect | ||
| github.com/go-openapi/swag/mangling v0.29.2 // indirect | ||
| github.com/go-openapi/swag/netutils v0.29.2 // indirect | ||
| github.com/go-openapi/swag/pools v0.29.2 // indirect | ||
| github.com/go-openapi/swag/stringutils v0.29.2 // indirect | ||
| github.com/go-openapi/swag/typeutils v0.29.2 // indirect | ||
| github.com/go-openapi/swag/yamlutils v0.29.2 // indirect | ||
| github.com/go-redis/cache/v9 v9.0.0 // indirect | ||
| github.com/gobwas/glob v0.2.3 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/golang-jwt/jwt/v4 v4.5.2 // indirect | ||
| github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect | ||
| github.com/golang/protobuf v1.5.4 // indirect | ||
| github.com/google/btree v1.1.3 // indirect | ||
| github.com/google/gnostic-models v0.6.9 // indirect | ||
| github.com/google/gnostic-models v0.7.0 // indirect | ||
| github.com/google/go-cmp v0.7.0 // indirect | ||
| github.com/google/go-github/v66 v66.0.0 // indirect | ||
| github.com/google/go-github/v75 v75.0.0 // indirect | ||
|
|
@@ -159,15 +148,17 @@ require ( | |
| k8s.io/component-helpers v0.31.2 // indirect | ||
| k8s.io/klog/v2 v2.140.0 // indirect | ||
| k8s.io/kube-aggregator v0.31.2 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20241212222426-2c72e554b1e7 // indirect | ||
| k8s.io/kube-openapi v0.0.0-20261014044854-ca3452a79603 // indirect | ||
| k8s.io/kubectl v0.31.2 // indirect | ||
| k8s.io/kubernetes v1.31.0 // indirect | ||
| k8s.io/utils v0.0.0-20260319190234-28399d86e0b5 // indirect | ||
| oras.land/oras-go/v2 v2.6.0 // indirect | ||
| sigs.k8s.io/json v0.0.0-20260909141634-11ed52e25bc5 // indirect | ||
| sigs.k8s.io/kustomize/api v0.21.1 // indirect | ||
| sigs.k8s.io/kustomize/kyaml v0.21.1 // indirect | ||
| sigs.k8s.io/randfill v1.0.0 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v4 v4.4.4-0.20241211184406-7bf59b3d70ee // indirect | ||
| sigs.k8s.io/structured-merge-diff/v7 v7.0.0 // indirect | ||
| sigs.k8s.io/yaml v1.6.0 // indirect | ||
| ) | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] api-contract
The go directive was changed from go 1.25.0 (with toolchain go1.26.3) to go 1.27.0 (with no toolchain directive). This raises the minimum required Go version to 1.27.0. However, the Dockerfile (line 2) uses golang:1.26-alpine and the CI workflow .github/workflows/tests.yml (lines 21, 61) uses go-version: 1.26 for both lint and test jobs. Neither is updated in this PR. With GOTOOLCHAIN=auto (the default since Go 1.21), Go 1.26 would attempt to auto-download Go 1.27 at build time, which is fragile in CI and container build environments (depends on network access, download server availability, and adds latency). If GOTOOLCHAIN=local is set or auto-download fails, builds will fail outright with a version mismatch error.
Suggested fix: Either (a) update the Dockerfile to golang:1.27-alpine and the CI workflow to go-version: 1.27 in this PR, or (b) keep the go 1.25.0 / toolchain go1.26.3 pair and find a version of kube-openapi that does not require Go 1.27. If Go 1.27 is intentional, the Dockerfile and CI must be updated in the same PR to avoid broken builds on main.