Skip to content

chore(deps): update module github.com/bombsimon/logrusr/v2 to v4 - #158

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x
Open

chore(deps): update module github.com/bombsimon/logrusr/v2 to v4#158
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/bombsimon/logrusr/v2 v2.0.1v4.1.0 age confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.


Release Notes

bombsimon/logrusr (github.com/bombsimon/logrusr/v2)

v4.1.0

Compare Source

What's Changed

Full Changelog: bombsimon/logrusr@v4.0.0...v4.1.0

v4.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v3.1.0...v4.0.0

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v3.0.0...v3.1.0

v3.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v2.0.1...v3.0.0


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from 80186c1 to f7bced7 Compare April 2, 2026 22:33
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from f7bced7 to aae291d Compare June 25, 2026 22:43
@red-hat-konflux
red-hat-konflux Bot requested a review from flacatus as a code owner June 25, 2026 22:43
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:54 PM UTC
Commit: 01f864b · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [api-contract] go.mod:37 — The PR changes an indirect dependency from github.com/bombsimon/logrusr/v2 v2.0.1 to github.com/bombsimon/logrusr/v4 v4.1.0. This is problematic for two reasons: (1) go.sum contains only checksums for logrusr/v2 and has no entries for logrusr/v4, which will cause go mod verify and builds to fail; (2) since logrusr is an indirect dependency pulled in by argo-cd/v2 v2.14.21, and Go treats /v2 and /v4 as distinct module paths, manually overriding the indirect entry from /v2 to /v4 does not satisfy argo-cd's actual import of logrusr/v2. After go mod tidy, Go will either revert to /v2 or pull in both /v2 and /v4, making this change incorrect or pointless.
    Remediation: Run go mod tidy to regenerate go.mod and go.sum consistently. This will resolve which version of logrusr the dependency graph actually requires. If only /v2 is needed (as expected given argo-cd v2.14.x), revert this change. The logrusr major version can only be upgraded when the consuming dependency (argo-cd) itself upgrades to use /v4.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Comment thread go.mod
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/bmatcuk/doublestar/v4 v4.10.0 // indirect
github.com/bombsimon/logrusr/v2 v2.0.1 // indirect
github.com/bombsimon/logrusr/v4 v4.1.0 // indirect

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] api-contract

The PR changes an indirect dependency from github.com/bombsimon/logrusr/v2 v2.0.1 to github.com/bombsimon/logrusr/v4 v4.1.0. This is problematic for two reasons: (1) go.sum contains only checksums for logrusr/v2 and has no entries for logrusr/v4, which will cause go mod verify and builds to fail; (2) since logrusr is an indirect dependency pulled in by argo-cd/v2 v2.14.21, and Go treats /v2 and /v4 as distinct module paths, manually overriding the indirect entry from /v2 to /v4 does not satisfy argo-cd's actual import of logrusr/v2. After go mod tidy, Go will either revert to /v2 or pull in both /v2 and /v4, making this change incorrect or pointless.

Suggested fix: Run go mod tidy to regenerate go.mod and go.sum consistently. This will resolve which version of logrusr the dependency graph actually requires. If only /v2 is needed (as expected given argo-cd v2.14.x), revert this change. The logrusr major version can only be upgraded when the consuming dependency (argo-cd) itself upgrades to use /v4.

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from aae291d to 84714ac Compare August 3, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants