chore(deps): update module github.com/bombsimon/logrusr/v2 to v4 - #158
chore(deps): update module github.com/bombsimon/logrusr/v2 to v4#158red-hat-konflux[bot] wants to merge 1 commit into
Conversation
80186c1 to
f7bced7
Compare
f7bced7 to
aae291d
Compare
|
🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:54 PM UTC |
ReviewFindingsHigh
|
| github.com/blang/semver/v4 v4.0.0 // indirect | ||
| github.com/bmatcuk/doublestar/v4 v4.10.0 // indirect | ||
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bombsimon/logrusr/v4 v4.1.0 // indirect |
There was a problem hiding this comment.
[high] api-contract
The PR changes an indirect dependency from github.com/bombsimon/logrusr/v2 v2.0.1 to github.com/bombsimon/logrusr/v4 v4.1.0. This is problematic for two reasons: (1) go.sum contains only checksums for logrusr/v2 and has no entries for logrusr/v4, which will cause go mod verify and builds to fail; (2) since logrusr is an indirect dependency pulled in by argo-cd/v2 v2.14.21, and Go treats /v2 and /v4 as distinct module paths, manually overriding the indirect entry from /v2 to /v4 does not satisfy argo-cd's actual import of logrusr/v2. After go mod tidy, Go will either revert to /v2 or pull in both /v2 and /v4, making this change incorrect or pointless.
Suggested fix: Run go mod tidy to regenerate go.mod and go.sum consistently. This will resolve which version of logrusr the dependency graph actually requires. If only /v2 is needed (as expected given argo-cd v2.14.x), revert this change. The logrusr major version can only be upgraded when the consuming dependency (argo-cd) itself upgrades to use /v4.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
aae291d to
84714ac
Compare
This PR contains the following updates:
v2.0.1→v4.1.0Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
bombsimon/logrusr (github.com/bombsimon/logrusr/v2)
v4.1.0Compare Source
What's Changed
logr.Marshalerby @bombsimon in #29Full Changelog: bombsimon/logrusr@v4.0.0...v4.1.0
v4.0.0Compare Source
What's Changed
FormatFuncreturn type to the expectedlogrus.Fieldstype by @d1egoaz in #23New Contributors
Full Changelog: bombsimon/logrusr@v3.1.0...v4.0.0
v3.1.0Compare Source
What's Changed
New Contributors
Full Changelog: bombsimon/logrusr@v3.0.0...v3.1.0
v3.0.0Compare Source
What's Changed
New Contributors
Full Changelog: bombsimon/logrusr@v2.0.1...v3.0.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.