Skip to content

chore(deps): update module github.com/bombsimon/logrusr/v2 to v4 - #158

Open
red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x
Open

red-hat-konflux[bot] wants to merge 1 commit into
mainfrom
konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jan 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
github.com/bombsimon/logrusr/v2 v2.0.1 → v4.2.0 age confidence

Release Notes

bombsimon/logrusr (github.com/bombsimon/logrusr/v2)

v4.2.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v4.1.0...v4.2.0

v4.1.0

Compare Source

What's Changed

Full Changelog: bombsimon/logrusr@v4.0.0...v4.1.0

v4.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v3.1.0...v4.0.0

v3.1.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v3.0.0...v3.1.0

v3.0.0

Compare Source

What's Changed

New Contributors

Full Changelog: bombsimon/logrusr@v2.0.1...v3.0.0


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from 80186c1 to f7bced7 Compare April 2, 2026 22:33
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from f7bced7 to aae291d Compare June 25, 2026 22:43
@red-hat-konflux
red-hat-konflux Bot requested a review from flacatus as a code owner June 25, 2026 22:43
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:54 PM UTC
Commit: 01f864b · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 25, 2026 •

Copy link
Copy Markdown

Review

Findings

High

  • [logic-error] go.mod:37 — The PR title and description claim to update github.com/bombsimon/logrusr/v2 from v2.0.1 to v4.2.0, but the dependency is completely unchanged. Line 37 of go.mod reads github.com/bombsimon/logrusr/v2 v2.0.1 // indirect in both the base branch and the PR head — the lines are byte-identical. No github.com/bombsimon/logrusr/v4 module entry was added anywhere in go.mod or go.sum. In Go modules, a v2-to-v4 major version bump requires changing the module path from /v2 to /v4 per the major version suffix convention. The Renovate bot was unable to perform this change and instead only bumped three unrelated transitive dependencies (testify v1.12.0→v1.12.1, logr v1.4.3→v1.4.4, logrus v1.9.4→v1.10.2). Additionally, logrusr is a transitive indirect dependency pulled in through ArgoCD — no Go source file in this repository imports it directly — so a standalone logrusr major version bump would likely need to be coordinated with an ArgoCD dependency update. Merging this PR would create a false record that logrusr was updated to v4 when it was not. If the v4 update was motivated by a security fix, API change, or compatibility requirement, that requirement remains unaddressed.
    Remediation: Either (1) correctly update to logrusr/v4 by adding github.com/bombsimon/logrusr/v4 to go.mod, removing the /v2 entry, and updating the transitive consumer (ArgoCD or its dependency tree) that requires it — or more practically, update the ArgoCD dependency first which would pull in the correct logrusr version transitively; or (2) retitle the PR to accurately reflect the actual changes (transitive dependency patch bumps for testify, logr, and logrus) and file a separate issue to track the logrusr v4 update if still desired.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run

Review

Findings

High

  • [logic error] go.mod:37 — PR claims to update github.com/bombsimon/logrusr/v2 from v2.0.1 to v4.2.0, but the dependency is unchanged at v2.0.1 (line 37). No logrusr/v4 module entry was added. In Go modules, a v2-to-v4 major version bump requires changing the module path from /v2 to /v4 and updating all transitive import paths. The Renovate bot appears to have been unable to perform this change and instead only bumped four unrelated transitive dependencies (testify, logr, logrus, yaml/v3). The PR is labeled ready-for-merge, so merging it will create the false impression that logrusr was updated to v4 when it was not. If the v4 update was motivated by a security fix, API change, or compatibility requirement, that requirement remains unaddressed.
    Remediation: Either (1) correctly update to logrusr/v4 by adding github.com/bombsimon/logrusr/v4 to go.mod, removing the /v2 entry, and updating all transitive consumers (likely within the ArgoCD dependency tree), or (2) retitle the PR to accurately reflect the actual changes (transitive dependency bumps) and investigate why the logrusr update failed, filing a separate issue if the v4 update is still desired.

Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR
Previous run (2)

Looks good to me

Previous run (3)

Review

Findings

High

  • [api-contract] go.mod:37 — The PR changes an indirect dependency from github.com/bombsimon/logrusr/v2 v2.0.1 to github.com/bombsimon/logrusr/v4 v4.1.0. This is problematic for two reasons: (1) go.sum contains only checksums for logrusr/v2 and has no entries for logrusr/v4, which will cause go mod verify and builds to fail; (2) since logrusr is an indirect dependency pulled in by argo-cd/v2 v2.14.21, and Go treats /v2 and /v4 as distinct module paths, manually overriding the indirect entry from /v2 to /v4 does not satisfy argo-cd's actual import of logrusr/v2. After go mod tidy, Go will either revert to /v2 or pull in both /v2 and /v4, making this change incorrect or pointless.
    Remediation: Run go mod tidy to regenerate go.mod and go.sum consistently. This will resolve which version of logrusr the dependency graph actually requires. If only /v2 is needed (as expected given argo-cd v2.14.x), revert this change. The logrusr major version can only be upgraded when the consuming dependency (argo-cd) itself upgrades to use /v4.

fullsend-ai-review[bot]

This comment was marked as outdated.

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from aae291d to 84714ac Compare August 3, 2026 15:34
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from 84714ac to d8acede Compare September 1, 2026 03:26
@red-hat-konflux

red-hat-konflux Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 3 additional dependencies were updated

Due to Go's usage of Minimal Version Selection (MVS), these packages have been updated to the minimum version available, so will still abide by minimumReleaseAge=3 days

Details:

Package Change
github.com/stretchr/testify v1.12.0 -> v1.12.1
github.com/go-logr/logr v1.4.3 -> v1.4.4
github.com/sirupsen/logrus v1.9.4 -> v1.10.2

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch 2 times, most recently from 14d72b5 to ad6b187 Compare September 25, 2026 21:24
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 9:25 PM UTC · Completed 9:36 PM UTC

Commit: ad6b187 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.18

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Sep 25, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Score anchored to prior 2 (moderate): bot-authored dependency bump touching only go.mod and go.sum with an 18-line diff; both dependency lock files modified drives Tier 1 up, but overall change size and protected-path signals are minimal; git history shows 3 fix/revert commits per file in 90 days and 3 distinct authors, sustaining the moderate composite.

Previous run

Risk Assessment: moderate (2/5)

Details

Score anchored to prior 2 (moderate): bot-authored dependency bump touching only go.mod and go.sum with a small diff (24 lines), but both dependency lock files are modified (Tier 1 sub-score 5) and git history confirms four fix/revert commits per file in the past 90 days, sustaining the non-trivial churn signal on the dependency surface that justified the prior score.

Previous run (2)

Risk Assessment: moderate (2/5)

Details

Bot-authored dependency bump touching only go.mod and go.sum with a small diff, but both dependency lock files are modified (elevated Tier 1 signal) and these files carry four fix/revert commits in the past 90 days, indicating non-trivial churn on the dependency surface.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review September 25, 2026 21:36

Superseded by updated review

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Sep 25, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from ad6b187 to 4e1fdcf Compare September 30, 2026 01:03
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 1:05 AM UTC · Completed 1:16 AM UTC

Commit: 4e1fdcf · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.44

fullsend-ai-review[bot]

This comment was marked as outdated.

fullsend-ai-review[bot]

This comment was marked as outdated.

@fullsend-ai-review
fullsend-ai-review Bot dismissed their stale review September 30, 2026 01:16

Superseded by updated review

@fullsend-ai-review fullsend-ai-review Bot removed the ready-for-merge All reviewers approved — ready to merge label Sep 30, 2026
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/main/github.com-bombsimon-logrusr-v2-4.x branch from 4e1fdcf to 990e58f Compare October 24, 2026 07:13
@fullsend-ai-review

fullsend-ai-review Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:15 AM UTC · Completed 7:25 AM UTC

Commit: 990e58f · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.10

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The following review comments could not be posted on the diff (GitHub returned 422) and are included here instead:

  • go.mod (file-level): Line 37 · [high] logic-error

The PR title and description claim to update github.com/bombsimon/logrusr/v2 from v2.0.1 to v4.2.0, but the dependency is completely unchanged. Line 37 of go.mod reads github.com/bombsimon/logrusr/v2 v2.0.1 // indirect in both the base branch and the PR head. No github.com/bombsimon/logrusr/v4 module entry was added. In Go modules, a v2-to-v4 major version bump requires changing the module path from /v2 to /v4. The Renovate bot only bumped three unrelated transitive dependencies (testify, logr, logrus). Merging this PR would create a false record that logrusr was updated to v4 when it was not.

Suggested fix: Either (1) correctly update to logrusr/v4 by updating the ArgoCD dependency first which would pull in the correct logrusr version transitively; or (2) retitle the PR to accurately reflect the actual changes (transitive dependency patch bumps) and file a separate issue to track the logrusr v4 update if still desired.

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants