Repository navigation
chore(deps): update module github.com/casbin/casbin/v2 to v3 - #159
red-hat-konflux[bot] wants to merge 1 commit into
Conversation
22b39d1 to
ff468fa
Compare
b3febfb to
703c60a
Compare
703c60a to
a72dfee
Compare
a72dfee to
b127e27
Compare
|
🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:56 PM UTC |
ReviewFindingsHigh
Low
Next steps:
Previous runReviewFindingsHigh
Low
Next steps:
Previous run (2)ReviewFindingsCritical
Low
Next steps:
Previous run (3)ReviewFindingsCritical
Medium
Low
|
b127e27 to
0cb22a0
Compare
7ab5818 to
760d655
Compare
|
🤖 Finished Review · ✅ Success · Started 9:25 PM UTC · Completed 9:39 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.87 |
|
Risk Assessment: moderate (2/5) DetailsTier 1 signals unchanged from prior assessment (same 2 dependency files, bot author, 7 lines, no protected or security-sensitive paths); composite 0.62x2.0 + 0.38x2.5 = 2.19 rounds to 2 (moderate), consistent with prior score anchoring despite elevated fix/revert history on dep files. Previous runRisk Assessment: moderate (2/5) DetailsTier 1 signals unchanged from prior assessment (same 2 dependency files, bot author, 7 lines, no protected or security-sensitive paths); composite score of 0.62x1.5 + 0.38x1.86 = 1.64 rounds to 2 (moderate), consistent with the prior score anchoring. Previous run (2)Risk Assessment: moderate (2/5) DetailsBot-generated dependency change touching only go.mod and go.sum with 7 lines changed. The dependency-file count and zero test ratio elevate the Tier 1 score, but the tiny change size, bot authorship, low churn, and no protected/security-sensitive paths keep overall risk moderate. |
760d655 to
d749d49
Compare
|
🤖 Finished Review · ✅ Success · Started 1:05 AM UTC · Completed 1:19 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.13 |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
d749d49 to
cba5312
Compare
|
🤖 Finished Review · ✅ Success · Started 7:15 AM UTC · Completed 7:29 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.36 |
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bradleyfalzon/ghinstallation/v2 v2.17.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.135.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.102.0 // indirect |
There was a problem hiding this comment.
[high] logic-error
The PR title claims to update casbin/casbin/v2 to v3, but the actual diff downgrades casbin/casbin/v2 from v2.135.0 to v2.102.0 (33 minor versions backward). The module path remains github.com/casbin/casbin/v2 — no v3 module path appears anywhere in the diff. The PR body's own release notes confirm the v3.0.0 breaking change: 'Module path changed from github.com/casbin/casbin/v2 to github.com/casbin/casbin/v3.' This is a Renovate bot misconfiguration. The go.sum confirms the downgrade is effective. Casbin is a purely indirect transitive dependency with zero direct Go imports, so practical runtime impact is minimal — but the downgrade is incorrect, the PR title is misleading, and no linked issue authorizes this change.
Suggested fix: Reject this PR. If a genuine v3 migration is desired, the module path must change to github.com/casbin/casbin/v3. If the intent is dependency management cleanup, open a new PR with an accurate title.
| github.com/bombsimon/logrusr/v2 v2.0.1 // indirect | ||
| github.com/bradleyfalzon/ghinstallation/v2 v2.17.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.135.0 // indirect | ||
| github.com/casbin/casbin/v2 v2.102.0 // indirect |
There was a problem hiding this comment.
[low] transitive-dependency-risk
Casbin is a transitive dependency via argoproj/argo-cd/v2 with zero direct imports in this codebase. The go.sum confirms the downgrade is effective (v2.135.0 checksums replaced by v2.102.0), meaning no other module in the dependency graph requires a casbin version higher than v2.102.0. Practical impact remains minimal since casbin is not directly imported.
This PR contains the following updates:
v2.135.0→v3.10.0Release Notes
casbin/casbin (github.com/casbin/casbin/v2)
v3.10.0Compare Source
Features
v3.9.0Compare Source
Features
v3.8.2Compare Source
Bug Fixes
v3.8.1Compare Source
Bug Fixes
v3.8.0Compare Source
Features
v3.7.0Compare Source
Features
v3.6.0Compare Source
Bug Fixes
Features
v3.5.2Compare Source
Bug Fixes
v3.5.1Compare Source
Bug Fixes
v3.5.0Compare Source
Features
v3.4.2Compare Source
Bug Fixes
v3.4.1Compare Source
Bug Fixes
v3.4.0Compare Source
Features
v3.3.0Compare Source
Features
v3.2.0Compare Source
Features
v3.1.0Compare Source
Features
v3.0.1Compare Source
Bug Fixes
v3.0.0Compare Source
BREAKING CHANGES
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.