chore(deps): update module github.com/go-git/gcfg to v2 - #160
chore(deps): update module github.com/go-git/gcfg to v2#160red-hat-konflux[bot] wants to merge 1 commit into
Conversation
ef8d717 to
71a61d8
Compare
71a61d8 to
49ba3e1
Compare
49ba3e1 to
373cc5d
Compare
373cc5d to
98b34c1
Compare
1f982e7 to
98b34c1
Compare
a338931 to
2bcfce3
Compare
2bcfce3 to
2edcaf6
Compare
2edcaf6 to
0b88791
Compare
0b88791 to
a6c992a
Compare
|
🤖 Finished Review · ✅ Success · Started 10:46 PM UTC · Completed 10:53 PM UTC |
ReviewFindingsHigh
Medium
Previous runReview —
|
| # | Severity | Category | File | Description |
|---|---|---|---|---|
| 1 | 🔴 critical | Dependency graph break | go.mod:57 |
go-git/go-git/v5 v5.13.2 requires gcfg v1, not gcfg/v2. These are distinct Go module paths — replacing one with the other removes a required transitive dependency and breaks the build. |
Recommendation
Do not merge this PR. The gcfg v1 dependency must remain in go.mod as long as go-git/go-git/v5 v5.13.2 requires it. This can only be resolved when go-git/go-git/v5 itself releases a version that depends on gcfg/v2 — at which point both go-git and gcfg should be upgraded together. The Renovate/MintMaker configuration may need adjustment to avoid treating Go major-version module path changes as simple version bumps.
Previous run (4)
Review
Findings
High
- [logic-error]
go.mod:57— This PR changes the indirect dependency fromgithub.com/go-git/gcfg(v1 module path) togithub.com/go-git/gcfg/v2(v2 module path). In Go modules, these are distinct modules with different import paths. The direct consumergithub.com/go-git/go-git/v5 v5.13.2(line 59) was released importinggithub.com/go-git/gcfg(v1). Manually replacing the v1 module path with v2 will not satisfy go-git's imports — go-git will still require the v1 module, and the build will fail. Additionally,go.sumcontains no checksums forgcfg/v2(only forgcfgv1), sogo mod verifywill also fail.
Remediation: Either (a) updatego-git/go-git/v5to a version that depends ongcfg/v2(if one exists) and rungo mod tidy, or (b) revert the gcfg change and letgo mod tidyresolve transitive dependencies correctly. Thego.summust also be regenerated to match.
Previous run (5)
Review
Findings
High
- [logic-error]
go.mod:57— This PR replaces the indirect dependencygithub.com/go-git/gcfg(v1 module path) withgithub.com/go-git/gcfg/v2(v2 module path). In Go modules, these are distinct modules. The consumer isgithub.com/go-git/go-git/v5 v5.13.2. If go-git v5.13.2 does not actually requiregcfg/v2, this change is incorrect — go-git would still transitively pull in v1, and the v2 entry would be unused or cause build failures. Additionally,go.sumhas not been updated: it contains checksums only forgcfg v1and has no entries forgcfg/v2, which means any build orgo mod verifywill fail regardless. Runninggo mod tidywould both validate whether gcfg/v2 is actually needed and regenerate go.sum with correct checksums.
Remediation: Rungo mod tidyand verify whether the resulting go.mod containsgcfg/v2orgcfgv1. If gcfg/v2 is needed, include the updated go.sum. If it is not needed, this change is incorrect and should not be merged.
|
🤖 Finished Review · ✅ Success · Started 5:29 PM UTC · Completed 5:37 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 5:44 PM UTC · Completed 5:51 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 2:18 PM UTC · Completed 2:22 PM UTC |
|
🤖 Finished Review · ✅ Success · Started 5:26 AM UTC · Completed 5:30 AM UTC |
|
🤖 Finished Review · ✅ Success · Started 4:39 PM UTC · Completed 4:50 PM UTC |
| github.com/fxamacker/cbor/v2 v2.7.0 // indirect | ||
| github.com/go-errors/errors v1.5.1 // indirect | ||
| github.com/go-git/gcfg v1.5.1-0.20230307220236-3a3c6141e376 // indirect | ||
| github.com/go-git/gcfg/v2 v2.0.2 // indirect |
There was a problem hiding this comment.
[high] dependency compatibility
The PR replaces github.com/go-git/gcfg v1.5.1-... with github.com/go-git/gcfg/v2 v2.0.2. However, go-git/go-git/v5 v5.13.2 (the sole consumer of this indirect dependency) still requires gcfg v1, not v2. Even the latest go-git release (v5.19.1) depends on gcfg v1. In Go modules, gcfg and gcfg/v2 are entirely distinct modules with different import paths — replacing v1 with v2 will break the module graph.
Suggested fix: Do not merge as-is. The v1 dependency must remain until go-git/go-git/v5 releases a version that imports gcfg/v2. Run go mod tidy to verify.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
This PR contains the following updates:
v1.5.1-0.20230307220236-3a3c6141e376→v2.0.2Release Notes
go-git/gcfg (github.com/go-git/gcfg)
v2.0.2Compare Source
What's Changed
New Contributors
Full Changelog: go-git/gcfg@v2.0.1...v2.0.2
v2.0.1Compare Source
What's Changed
New Contributors
Full Changelog: go-git/gcfg@v2.0.0...v2.0.1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.