KFLUXINFRA-3014: Deploy TektonConfig w/ ArgoCD on kflux-c-stg-i01#270
KFLUXINFRA-3014: Deploy TektonConfig w/ ArgoCD on kflux-c-stg-i01#270enkeefe00 wants to merge 1 commit into
Conversation
|
@enkeefe00: This pull request references KFLUXINFRA-3014 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@enkeefe00: This pull request references KFLUXINFRA-3014 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
enkeefe00
force-pushed
the
update-tekton-cfgs
branch
from
c739d69 to
5c503ca
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enkeefe00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@enkeefe00: This pull request references KFLUXINFRA-3014 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
aThorp96
left a comment
aThorp96
left a comment
There was a problem hiding this comment.
General approach seems fine. Couple gaps between this and the configmap included in ../base which may cause argo to flap. If possible, this should replace the ConfigMap entirely since it will overwrite the ConfigMap on sync
| metrics.taskrun.level: task | ||
| trusted-resources-verification-no-match-policy: ignore | ||
| metrics.pipelinerun.level: pipeline | ||
| enable-api-fields: beta |
There was a problem hiding this comment.
This should be alpha, per the configmap
| keep-pod-on-cancel: false | ||
| enable-provenance-in-status: true | ||
| enable-custom-tasks: true | ||
| disable-creds-init: false |
There was a problem hiding this comment.
This should be true per the configmap (not sure if true or "true")
| enable-custom-tasks: true | ||
| disable-creds-init: false | ||
| options: {} | ||
| disable-affinity-assistant: true |
There was a problem hiding this comment.
This should be false per the configmap (maybe "false")
| disabled: false | ||
| artifacts.oci.format: simplesigning | ||
| options: {} | ||
| pipeline: |
There was a problem hiding this comment.
There's a couple settings in the configmap which aren't set here. That might be fine, but wanted to flag in case they're non-default since this would overwrite the configmap.
enable-kubernetes-sidecardisable-inline-specenable-concise-resolver-syntaxenable-tekton-oci-bundlesenable-artifacts
@aThorp96 If the fields aren't present in the existing |
|
@enkeefe00 if the fields weren't present on the TektonConfig you would only need to add them if they're not the defaults (I'll have to check if those fields have default values set). If you explicitly have a different value than the configmap in the cluster it will overwrite the configmap when the Teknton Config syncs, which would explain why the configmap may be different in the cluster. I don't know which of the values you want, but I assume the VCS' config is what is expected |
Since previous attempts to disable Tekton Results failed (see redhat-appstudio#269 and redhat-appstudio#254) , deploy a disabled Tekton Results `TektonConfig` to allow ArgoCD to manage the resource instead of the openshift-pipelines operator. Assisted-by: Gemini KFLUXINFRA-3014
enkeefe00
force-pushed
the
update-tekton-cfgs
branch
from
5c503ca to
e5bce20
Compare
4 participants
Since previous attempts to disable Tekton Results failed (see #269 and #254) , deploy a disabled Tekton Results
TektonConfigto allow ArgoCD to manage the resource instead of the openshift-pipelines operator.Assisted-by: Gemini
KFLUXINFRA-3014