Skip to content

fix: remove argocd-update and uses http for sync verification#528

Open
Troy876 wants to merge 1 commit into
redhat-appstudio:mainfrom
Troy876:KFLUXDP-1045-k8s-api-fix
Open

fix: remove argocd-update and uses http for sync verification#528
Troy876 wants to merge 1 commit into
redhat-appstudio:mainfrom
Troy876:KFLUXDP-1045-k8s-api-fix

Conversation

@Troy876

@Troy876 Troy876 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Replaces argocd-update with a read-only k8s call via http to avoid breaking gitops.

Jira: https://redhat.atlassian.net/browse/KFLUXDP-1045

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

Hi @Troy876. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qodo-for-redhat-appstudio

Copy link
Copy Markdown

Code Review by Qodo

Grey Divider

Sorry, something went wrong

We weren't able to complete the code review on our side. Please try again

Grey Divider

Qodo Logo

@p8r-the-gr8

Copy link
Copy Markdown
Contributor

/lgtm

@p8r-the-gr8

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: p8r-the-gr8, Troy876
Once this PR has been reviewed and has the lgtm label, please assign arewm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Troy876 Troy876 force-pushed the KFLUXDP-1045-k8s-api-fix branch from 88ce0f7 to 058824a Compare July 3, 2026 12:24
@openshift-ci openshift-ci Bot removed the lgtm label Jul 3, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@Troy876 Troy876 force-pushed the KFLUXDP-1045-k8s-api-fix branch from 058824a to 616bd31 Compare July 3, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants