Add TektonConfig resource to internal-staging - #580
Open
gbenhaim wants to merge 1 commit into
Open
Conversation
The previous tekton-config-patch.yaml was defined as a kustomize strategic merge patch targeting TektonConfig/config, but no base TektonConfig resource existed in the kustomization — so the patch was silently skipped and result.disabled never took effect. Convert it to a standalone resource (tekton-config.yaml) referenced directly in the kustomization resources list. Assisted-by: Cursor Signed-off-by: Gal Ben Haim <gbenhaim@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
internal-stagingresults.disabled: trueactually take effectEnvironments affected: internal-staging
Why
The previous
tekton-config-patch.yamlwas a kustomize strategic merge patch targetingTektonConfig/config, but no base TektonConfig resource existed in the kustomization — so the patch was silently skipped andresults.disablednever took effect.Validation
kustomize buildpasses for all four overlaysMade with Cursor