feat(KONFLUX-15435): Add perf-team-prometheus-reader production overlays

[smodak-rh]

Summary

Add production environment overlays for the perf-team-prometheus-reader component on common clusters.

This follows the staging-first rollout per review feedback on PR #791. Do not merge until staging (PR #791) is deployed and verified.

Change

• components/perf-team-prometheus-reader/internal-production/kustomization.yaml
• components/perf-team-prometheus-reader/external-production/kustomization.yaml

Both reference ../base (same resources as staging).

Related

• Staging PR: #791
• Jira: KONFLUX-15435

Signed-off-by: Subrata Modak smodak@redhat.com
Assisted-by: ClaudeAI

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smodak-rh
Once this PR has been reviewed and has the lgtm label, please assign manish-jangra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-for-redhat-appstudio]

PR Summary by Qodo

Add production overlays for Prometheus reader

✨ Enhancement ⚙️ Configuration changes 🕐 Less than 5 minutes

AI Description

• Add internal and external production overlays for the Prometheus reader.
• Reuse validated base resources across common production clusters.
• Preserve the staging-first rollout by awaiting staging verification before merge.

Diagram

graph TD
  External["External production"] --> Base["Shared base"] --> Namespace["Reader namespace"]
  Internal["Internal production"] --> Base

Loading

High-Level Assessment

Reusing the existing base from both production overlays is the appropriate approach because it matches staging, minimizes environment drift, and avoids duplicating manifests. Environment-specific production patches can be added later if operational requirements diverge.

Files changed (2) +12 / -0

Other (2) +12 / -0

kustomization.yamlAdd external production Kustomize overlay +6/-0

Add external production Kustomize overlay

• Adds the external production entry point for perf-team-prometheus-reader. It targets the component namespace and composes the existing base resources.

components/perf-team-prometheus-reader/external-production/kustomization.yaml

kustomization.yamlAdd internal production Kustomize overlay +6/-0

Add internal production Kustomize overlay

• Adds the internal production entry point for perf-team-prometheus-reader. It targets the component namespace and composes the same base resources used by staging.

components/perf-team-prometheus-reader/internal-production/kustomization.yaml

[qodo-for-redhat-appstudio]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📜 Skill insights (0)

1. Referenced base is missing 📘 Rule violation ☼ Reliability

Description

Both new production overlays reference ../base, but this component currently has no base/
directory or sibling staging overlays, so Kustomize cannot render either overlay. Merging before the
staging prerequisite is incorporated leaves both production paths invalid and the component without
the required base-and-sibling-overlay layout.

Code

components/perf-team-prometheus-reader/external-production/kustomization.yaml[R5-6]

+resources:
+- ../base

Relevance

●●● Strong

Production overlays cannot render until staging adds the referenced base; repository history accepts
build-blocking deployment issues.

PR-#661
PR-#484

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

Rules 1101 and 1104 require buildable overlays and a component-local base/ with sibling
environment overlays. Each added Kustomization references the same relative ../base, while
repository inspection found only the two production Kustomization files under this component and no
base, internal-staging, or external-staging directory or Kustomization; because the repository
workflow discovers component Kustomizations for building, both unresolved resource paths would fail
validation.

Rule 1101: All kustomize overlays must build successfully before submission
Rule 1104: Enforce Kustomize component directory layout with base and overlays
components/perf-team-prometheus-reader/external-production/kustomization.yaml[5-6]
components/perf-team-prometheus-reader/internal-production/kustomization.yaml[5-6]
.github/workflows/kube-linter.yaml[42-53]
components/perf-team-prometheus-reader/external-production/kustomization.yaml[4-6]
components/perf-team-prometheus-reader/internal-production/kustomization.yaml[4-6]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Both production overlays reference `../base`, but that directory is absent from the current branch, causing Kustomize rendering to fail and leaving the required component layout incomplete.

## Issue Context
The PR description identifies the related staging change as a prerequisite that may provide the missing base and staging overlays. Ensure this branch includes or is rebased onto those resources before submission, rather than relying only on merge-order documentation, so all four variants are present and build successfully in CI.

## Fix Focus Areas
- components/perf-team-prometheus-reader/external-production/kustomization.yaml[5-6]
- components/perf-team-prometheus-reader/internal-production/kustomization.yaml[5-6]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Context sources

⚠️ Tickets: not configured — ticket URL found in PR but could not be fetched — check ticket provider credentials

✅ Compliance rules (platform): 5 rules

Tip of the day

💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[qodo-for-redhat-appstudio]

1. Referenced base is missing 📘 Rule violation ☼ Reliability

Both new production overlays reference ../base, but this component currently has no base/
directory or sibling staging overlays, so Kustomize cannot render either overlay. Merging before the
staging prerequisite is incorporated leaves both production paths invalid and the component without
the required base-and-sibling-overlay layout.

Agent Prompt

## Issue description
Both production overlays reference `../base`, but that directory is absent from the current branch, causing Kustomize rendering to fail and leaving the required component layout incomplete.

## Issue Context
The PR description identifies the related staging change as a prerequisite that may provide the missing base and staging overlays. Ensure this branch includes or is rebased onto those resources before submission, rather than relying only on merge-order documentation, so all four variants are present and build successfully in CI.

## Fix Focus Areas
- components/perf-team-prometheus-reader/external-production/kustomization.yaml[5-6]
- components/perf-team-prometheus-reader/internal-production/kustomization.yaml[5-6]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

[smodak-rh]

The scan CI failure is expected — the production overlays reference ../base which doesn't exist on main yet. It's part of PR #791 (staging). Once #791 merges, this PR's CI will pass.

This PR should not be merged until #791 is deployed and verified on staging.