Skip to content

Comments

platform normalization in no-skip policy#10634

Open
filariow wants to merge 1 commit intoredhat-appstudio:mainfrom
filariow:fix-kueue-no-skip-policy
Open

platform normalization in no-skip policy#10634
filariow wants to merge 1 commit intoredhat-appstudio:mainfrom
filariow:fix-kueue-no-skip-policy

Conversation

@filariow
Copy link
Member

This is only affecting development and staging clusters.

PLATFORM values are normalized before being put in the annotation. We need to apply the same change here.

cf. https://github.com/redhat-appstudio/infra-deployments/blob/68dd5035f4b8ae2a21c375cc45d1aa45762116e2/components/kueue/development/tekton-kueue/config.yaml\#L13C29-L13C47

Signed-off-by: Francesco Ilario filario@redhat.com

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

@github-actions
Copy link
Contributor

🤖 Gemini AI Assistant Available

Hi @filariow! I'm here to help with your pull request. You can interact with me using the following commands:

Available Commands

  • @gemini-cli /review - Request a comprehensive code review

    • Example: @gemini-cli /review Please focus on security and performance
  • @gemini-cli <your question> - Ask me anything about the codebase

    • Example: @gemini-cli How can I improve this function?
    • Example: @gemini-cli What are the best practices for error handling here?

How to Use

  1. Simply type one of the commands above in a comment on this PR
  2. I'll analyze your code and provide detailed feedback
  3. You can track my progress in the workflow logs

Permissions

Only OWNER, MEMBER, or COLLABORATOR users can trigger my responses. This ensures secure and appropriate usage.


This message was automatically added to help you get started with the Gemini AI assistant. Feel free to delete this comment if you don't need assistance.

@github-actions
Copy link
Contributor

🤖 Hi @filariow, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

This is only affecting development and staging clusters.

PLATFORM values are normalized before being put in the
annotation. We need to apply the same change here.

cf. https://github.com/redhat-appstudio/infra-deployments/blob/68dd5035f4b8ae2a21c375cc45d1aa45762116e2/components/kueue/development/tekton-kueue/config.yaml\#L13C29-L13C47

Signed-off-by: Francesco Ilario <filario@redhat.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@filariow
Copy link
Member Author

@gbenhaim fyi: prod label is wrong here

Copy link
Contributor

@hugares hugares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, hugares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants