Skip to content

Promote release-service and grafana-dashboard from development to staging#12768

Merged
openshift-merge-bot[bot] merged 1 commit into
redhat-appstudio:mainfrom
seanconroy2021:release-service-staging-update-2026_06_25__10_14_27
Jun 25, 2026
Merged

Promote release-service and grafana-dashboard from development to staging#12768
openshift-merge-bot[bot] merged 1 commit into
redhat-appstudio:mainfrom
seanconroy2021:release-service-staging-update-2026_06_25__10_14_27

Conversation

@openshift-ci

openshift-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanconroy2021

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Kustomize Render Diff

Comparing c1e766b2024c62ca60

Component Environment Changes
components/release/staging staging +1 -1

Total: 1 components, +1 -1 lines

📋 Full diff available in the workflow summary and as a downloadable artifact.

@qodo-for-redhat-appstudio

Copy link
Copy Markdown

PR Summary by Qodo

Promote release-service and Grafana release dashboard to staging refs
⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

Description

• Bump staging release-service deployment to commit ref 6d9abf25.
• Update staging Grafana release dashboards to the same release-service ref.
Diagram

graph TD
  A["components/release/staging/kustomization.yaml"] --> B{{"release-service config/default (ref 6d9abf25)"}} --> C{{"quay.io/konflux-ci/release-service:6d9abf25"}}
  D["components/monitoring/grafana/staging/dashboards/release/kustomization.yaml"] --> E{{"release-service config/grafana (ref 6d9abf25)"}}
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Centralize the ref in a single staging component/var
  • ➕ Avoids duplicated SHA bumps across multiple kustomizations
  • ➕ Reduces risk of staging deploying mismatched dashboard vs service versions
  • ➖ Requires repo-wide wiring changes (kustomize component/vars) beyond a simple promotion
  • ➖ May not fit existing environment promotion workflow
2. Promote via immutable release tags instead of commit SHAs
  • ➕ More human-readable provenance (e.g., vX.Y.Z)
  • ➕ Can align with a formal release process and changelogs
  • ➖ Requires tagging discipline and changes to current promotion automation
  • ➖ If tags move or are reused, can reduce immutability guarantees

Recommendation: The current approach (pinning staging to a specific commit SHA in both service manifests and Grafana dashboards) is appropriate for a straightforward promotion and keeps environments reproducible. If promotions frequently require bumping multiple files, consider centralizing the ref to reduce drift and manual coordination.

Files changed (2) +3 / -3

Other (2) +3 / -3
kustomization.yamlBump staging Grafana release dashboards to new release-service ref +1/-1

Bump staging Grafana release dashboards to new release-service ref

• Updates the remote kustomize resource URL for Grafana dashboard config to point at release-service ref 6d9abf25, promoting the latest dashboard definitions into staging.

components/monitoring/grafana/staging/dashboards/release/kustomization.yaml

kustomization.yamlPromote staging release-service manifests and image tag to ref 6d9abf25 +2/-2

Promote staging release-service manifests and image tag to ref 6d9abf25

• Pins the staging kustomization to the release-service config/default at ref 6d9abf25 and updates the deployed quay.io/konflux-ci/release-service image tag to the same ref to keep manifests and runtime aligned.

components/release/staging/kustomization.yaml

@qodo-for-redhat-appstudio

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@mmalina

mmalina commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.32%. Comparing base (c1e766b) to head (ce1afc2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12768   +/-   ##
=======================================
  Coverage   53.32%   53.32%           
=======================================
  Files          20       20           
  Lines        1309     1309           
=======================================
  Hits          698      698           
  Misses        539      539           
  Partials       72       72           
Flag Coverage Δ
go 53.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-merge-bot openshift-merge-bot Bot merged commit bb40423 into redhat-appstudio:main Jun 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants