-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kyverno: rollout to dev overlay & production #5326
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest splitting in two. One for staging+dev, the other for prod.
I've filed a PR (#5327) to deploy kyverno to the rest of staging. Once that merges, I'll unhold this PR and continue the rollout to production. /hold |
8d0adee
to
03cab7a
Compare
/unhold #5327 has been merged, and the new deployments appear stable. |
metadata: | ||
name: kyverno | ||
$patch: delete | ||
--- | ||
apiVersion: argoproj.io/v1alpha1 | ||
kind: ApplicationSet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will deploy to development with 3 replicas for each controller. That may be too much. I'd suggest to add an overlay for development where we explicitly set 1 replica for each Kyverno controller. We could also disable Report ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 4b1460f.
03cab7a
to
4b1460f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: filariow, sadlerap The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
Kyverno's deployments in the staging environments have stabilized at this point, so it's safe to continue the rollout to production. Signed-off-by: Andy Sadler <[email protected]>
To reduce the number of resources needed, set the replicas for each deployment down to 1. Signed-off-by: Andy Sadler <[email protected]>
4b1460f
to
d7df5ed
Compare
New changes are detected. LGTM label has been removed. |
@sadlerap: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/hold #5527 should merge first |
Kyverno's deployments in the staging environments have stabilized at this point, so it's safe to continue the rollout to production.