Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyverno: rollout to dev overlay & production #5326

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sadlerap
Copy link
Contributor

Kyverno's deployments in the staging environments have stabilized at this point, so it's safe to continue the rollout to production.

Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest splitting in two. One for staging+dev, the other for prod.

@sadlerap
Copy link
Contributor Author

I've filed a PR (#5327) to deploy kyverno to the rest of staging. Once that merges, I'll unhold this PR and continue the rollout to production.

/hold

@sadlerap
Copy link
Contributor Author

sadlerap commented Feb 4, 2025

/unhold

#5327 has been merged, and the new deployments appear stable.

Comment on lines -124 to -129
metadata:
name: kyverno
$patch: delete
---
apiVersion: argoproj.io/v1alpha1
kind: ApplicationSet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will deploy to development with 3 replicas for each controller. That may be too much. I'd suggest to add an overlay for development where we explicitly set 1 replica for each Kyverno controller. We could also disable Report ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 4b1460f.

Copy link
Member

@filariow filariow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: filariow, sadlerap
Once this PR has been reviewed and has the lgtm label, please assign lcarva for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor Author

sadlerap commented Feb 6, 2025

/retest

@sadlerap sadlerap changed the title kyverno: rollout to production kyverno: rollout to dev overlay & production Feb 10, 2025
@sadlerap
Copy link
Contributor Author

/retest

Kyverno's deployments in the staging environments have stabilized at
this point, so it's safe to continue the rollout to production.

Signed-off-by: Andy Sadler <[email protected]>
To reduce the number of resources needed, set the replicas for each
deployment down to 1.

Signed-off-by: Andy Sadler <[email protected]>
Copy link

openshift-ci bot commented Feb 10, 2025

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Feb 10, 2025

@sadlerap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests d7df5ed link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadlerap
Copy link
Contributor Author

/hold

#5527 should merge first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants