Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Role For Monitoring Release Pipelines #5818

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rhartman93
Copy link

We want to create a service account that can be used by users to automate monitoring the status of their managed release pipelines. The thought for now is it will only require:

  • get
  • list
  • watch

permissions for:

  • pipelineruns
  • pipelines
  • pods
  • pods/logs

@openshift-ci openshift-ci bot requested review from davidmogar and johnbieren March 14, 2025 16:42
Copy link

openshift-ci bot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhartman93
Once this PR has been reviewed and has the lgtm label, please assign davidmogar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 14, 2025

Hi @rhartman93. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
name: monitor-release-pipeline-role
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be used for any type of pipeline though

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying I should rename it to be more generic? or suggesting that there's a way I could make the role more tailored to release pipelines?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more generic

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

name: monitor-release-pipeline-role
rules:
- apiGroups:
- tekton.dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may have to separate the tekton and the core ones?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gbenhaim
Copy link
Member

| We want to create a service account that can be used by users to automate monitoring the status of their managed
is it going to be a single service account that will be used by multiple users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants