Application-layer new-cluster automation #6226
Open
+5,078
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ralphbean The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The API isn't giving the response I expected.
ralphbean
requested review from
hugares,
manish-jangra and
enkeefe00
and removed request for
skabashnyuk and
jgwest
I want it to be able to run with --tags vault and have that make sense.
|
@ralphbean If you're referring to kms key for the velero backup in the description of this PR, we will not use that anymore for new environments as we're creating s3 bucket (for velero backup) using the default s3 encryption managed by aws itself. We can always change that if we need to and change terraform module to create kms key for the velero backup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing that's up in the air here is dealing with the valero backup key. I assume that is waiting on some new work to be done in the cluster-level automation and can be followed up on later.