fix: running ir shold not be removed #6244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR fixes the case where a running IR is wrongly removed by the cronjob due to the missing completionTime field, that is only added after finishing the IR run. Signed-off-by: Leandro Mendes <[email protected]>
theflockers
force-pushed
the
fix_cronjob
branch
from
7d802c5 to
d7251a4
Compare
mmalina
reviewed
Apr 28, 2025
mmalina
approved these changes
Apr 29, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmalina, theflockers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 369e961
into
redhat-appstudio:main
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes the case where a running IR is
wrongly removed by the cronjob due to the missing
completionTime field, that is only added after
finishing the IR run.