Skip to content

build-service update #6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fmudry
Copy link

@fmudry fmudry commented Apr 29, 2025

Updating build-service refs.

Included PR: konflux-ci/build-service#427

@openshift-ci openshift-ci bot requested review from chmeliik and mkosiarc April 29, 2025 10:30
Copy link

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmudry
Once this PR has been reviewed and has the lgtm label, please assign mmorhun for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Apr 29, 2025

Hi @fmudry. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chmeliik
Copy link
Member

/ok-to-test

@chmeliik
Copy link
Member

FYI this also includes the update from #6252.

If the CI passes here, we should merge this and close #6252

@chmeliik
Copy link
Member

/ok-to-test

@chmeliik
Copy link
Member

/ok-to-test

Copy link

openshift-ci bot commented Apr 29, 2025

@fmudry: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-e2e-tests cd0a522 link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tisutisu
Copy link
Member

Looking at the failed test, we need to change the value here as well

@chmeliik
Copy link
Member

chmeliik commented May 2, 2025

Looking at the failed test, we need to change the value here as well

There is a PR open to fix the e2e-tests: konflux-ci/e2e-tests#1576

But it looks like it isn't updating the value you mentioned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants