Skip to content

removing livenessProbe #6258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Conversation

rubenmgx
Copy link
Contributor

Based on the conversation on https://issues.redhat.com/browse/SPRE-1255 we will be removing the livenessProbe since is not meeting the expectations

Copy link

openshift-ci bot commented Apr 29, 2025

Hi @rubenmgx. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gbenhaim
Copy link
Member

/approve
/lgtm

@gbenhaim gbenhaim closed this Apr 29, 2025
@gbenhaim gbenhaim reopened this Apr 29, 2025
@gbenhaim
Copy link
Member

/approve
/lgtm

Copy link

openshift-ci bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gbenhaim, rubenmgx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rubenmgx
Copy link
Contributor Author

rubenmgx commented May 2, 2025

hey @amisstea could you please check this PR? Thanks a lot!

@amisstea
Copy link
Contributor

amisstea commented May 2, 2025

/ok-to-test

@psturc
Copy link
Member

psturc commented May 3, 2025

/retest-required

Copy link

openshift-ci bot commented May 3, 2025

@rubenmgx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-upgrade-tests 595a1bd link false /test appstudio-upgrade-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rubenmgx
Copy link
Contributor Author

rubenmgx commented May 5, 2025

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 6a08b1d into redhat-appstudio:main May 5, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants