Skip to content

add konflux-viewer-user-actions role to stg and prod #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

filariow
Copy link
Member

Add the konflux-viewer-user-actions role. It provides the same rights the konflux-contributor-user-actions role provides.
It is required for the implementation of Public view feature.

Signed-off-by: Francesco Ilario [email protected]

Add the konflux-viewer-user-actions role. It provides the same rights
konflux-contributor-user-actions role provides. It is required for
Public view implementation.

Signed-off-by: Francesco Ilario <[email protected]>
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow, sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5a109b4 into redhat-appstudio:main May 1, 2025
9 checks passed
@filariow filariow deleted the konflux-viewer-role branch May 1, 2025 22:35
@gbenhaim
Copy link
Member

gbenhaim commented May 5, 2025

@filariow if the role need to appear in the ui, you should add it in this configmap as well https://github.com/redhat-appstudio/infra-deployments/blob/main/components/konflux-info/staging/stone-stage-p01/info.json#L24
(each cluster has its own configmap)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants