Skip to content

Align pipeline-service base with cluster configs #6272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

enarha
Copy link
Contributor

@enarha enarha commented Apr 30, 2025

Some changes were done without running the generate-deploy-config.sh script which keeps the deploy.yaml files aligned with the base. This PR does not introduce new changes, but just aligns the configs with the base.

Some changes were done without running the generate-deploy-config.sh
script which keeps the deploy.yaml files aligned with the base. This PR
does not introduce new changes, but just aligns the configs with the
base.
Copy link
Contributor

@aThorp96 aThorp96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

One question regarding some of the values

Comment on lines -2465 to +2466
custom-console-url: https://konflux-ui.apps.stone-stg-rh01.l2vh.p1.openshiftapps.com/
custom-console-url-pr-details: https://konflux-ui.apps.stone-stg-rh01.l2vh.p1.openshiftapps.com/ns/{{
custom-console-url: https://console.dev.redhat.com/application-pipeline
custom-console-url-pr-details: https://console.dev.redhat.com/application-pipeline/ns/{{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL seems to be diverging from the other staging deployment. Do you know if that's intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know that for sure. Sometimes people are only updating a single cluster when they want to test a change at smaller scale. Having said that, I'm not worried about this one as #6262 updates these again and BTW this is how we found out about the inconsistency.

Copy link

openshift-ci bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aThorp96, enarha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 97e70ec into redhat-appstudio:main Apr 30, 2025
9 checks passed
@enarha enarha deleted the align-staging-base branch April 30, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants