Skip to content

Revert "[dev+stage] Add SCC for nested containerization (#6127)" #6308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chmeliik
Copy link
Member

@chmeliik chmeliik commented May 6, 2025

This reverts commit e39a666.

We decided not to go down this route due to concerns about weakening cluster security by allowing pods to use the container_runtime_t label.

More details in STONEBLD-3325

…udio#6127)"

This reverts commit e39a666.

We decided not to go down this route due to concerns about weakening
cluster security by allowing pods to use the container_runtime_t label.

Signed-off-by: Adam Cmiel <[email protected]>
@openshift-ci openshift-ci bot requested review from ramessesii2 and Roming22 May 6, 2025 14:13
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chmeliik
Once this PR has been reviewed and has the lgtm label, please assign roming22, sadlerap for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@enarha enarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tisutisu
Copy link
Member

tisutisu commented May 7, 2025

/retest

@chmeliik
Copy link
Member Author

chmeliik commented May 7, 2025

@filariow could you take a look as well? This is reverting the changes done in #6127

@filariow
Copy link
Member

filariow commented May 7, 2025

/lgtm

@chmeliik
Copy link
Member Author

chmeliik commented May 7, 2025

@enarha I think this should be ready for approval 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants