Add kueue component #6358
Add kueue component #6358
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbenhaim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gbenhaim
force-pushed
the
add-kueue-component
branch
from
b487ab0 to
15622d6
Compare
|
/test konflux-e2e-v416-optional |
|
/test |
|
@gbenhaim: The The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test appstudio-e2e-tests |
There was a problem hiding this comment.
I'm failing to understand why we need cert-manager. Could you maybe provide some clarity on why openshift's certificate management capabilities isn't used?
I'm hoping we can continue to keep certificate management controlled by openshift on our clusters, not split between it and cert-manager.
| kind: Namespace | ||
| metadata: | ||
| name: openshift-kueue-operator | ||
| spec: {} |
There was a problem hiding this comment.
| spec: {} |
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: admin |
There was a problem hiding this comment.
Why do we need to grant this service account admin rights on the namespace?
| requests: | ||
| cpu: "100m" | ||
| memory: "128Mi" | ||
| limits: | ||
| cpu: "200m" | ||
| memory: "256Mi" |
There was a problem hiding this comment.
Should we set the requests and the limits to be the same to avoid pod evictions?
gbenhaim
force-pushed
the
add-kueue-component
branch
from
448b7d4 to
dad9ff1
Compare
|
/test konflux-e2e-v416-optional |
The kueue extensions will enable the use of Kueue with Tekton and controlling workload admission based on control plane alerts. Signed-off-by: Gal Ben Haim <[email protected]>
It's required for running Kueue and its extensions. Signed-off-by: Gal Ben Haim <[email protected]>
- Add the manifests for deploying Kueue using the RH operator. Since wasn't released yet (and it doesn't have an index image), use operator-sdk for installing it. - Add the ArgoCD AppSet for Kueue. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
The configmap is used for telling the admission controller if it need to admit workloads. This is a temporary solution until the integration with alert manager will by implemented. Signed-off-by: Gal Ben Haim <[email protected]>
It's not possible to install it on earlier versions. Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
Signed-off-by: Gal Ben Haim <[email protected]>
|
/test konflux-e2e-v416-optional |
gbenhaim
force-pushed
the
add-kueue-component
branch
from
dad9ff1 to
b653014
Compare
|
/test konflux-e2e-v416-optional |
|
@gbenhaim: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Install kueue and the plugins for supporting tekton pipelineruns and external admission.
Install only as part of the development overlay and only on OCP cluster with version >= 4.16 (the kueue operator doesn't work on earlier version).
ATM, the index image for the RH productized version of Kueue isn't yet ready, because of that it's being installed using the
operator-frameworkcli.