Add testplatform ProviderConfig #6446
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: danilo-gemoli The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @danilo-gemoli. Thanks for your PR. I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| spec: | ||
| dataFrom: | ||
| - extract: | ||
| key: production/openshift-ci/ephemeral-cluster |
There was a problem hiding this comment.
It seems odd for this key to have ephemeral in the name. Is it expected to be short lived?
There was a problem hiding this comment.
ephemeral-cluster relates to the work I'm carrying on. The kubeconfig I'm extracting here is related to our main cluster appci. I can rename it into production/openshift-ci/appci if this sounds better to you.
There was a problem hiding this comment.
Yeah, or appci-cluster just to be extra clear.
There was a problem hiding this comment.
It's typical to deploy and test with the staging env first before deploying to prod. Is there a staging test platform cluster we can use?
There was a problem hiding this comment.
Unfortunately in TestPlatform we don't have any staging environment, but we rather test in production.
There was a problem hiding this comment.
Ok. In that case, let's deploy the same configs in the staging env so it can at least be tested from there.
There was a problem hiding this comment.
Staging env here: #6449
There was a problem hiding this comment.
Great, let's focus on getting that one merged and tested in staging first.
|
/ok-to-test |
Add a new
ProviderConfigfor crossplane. This is going to be needed in order to access the TestPlatformappcicluster via akubeconfigstored into the Vault.