Skip to content

fix(RELEASE-1645): allow serviceaccounts to see cm #6450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(RELEASE-1645): allow serviceaccounts to see cm #6450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions components/pipeline-service/base/rbac/openshift-pipelines/configmap-viewer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
# Grant access to authenticated users to be able to view
# openshift-pipelines configMaps. The user case involves
# service accounts running automated tests being able to
# discover the custom URL for the Konflux UI
Comment on lines +2 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the "why" comment here. Since this is going to apply to all users, is there any risk in all users having read access to configmaps? I'm wondering if the the automated testing serviceaccounts have a shared group which this rolebinding can use as its subject instead of all authenticated users

kind: Role
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: configmap-viewer
namespace: openshift-pipelines
rules:
- verbs:
- get
- watch
- list
apiGroups:
- ''
resources:
- configmaps
---
kind: RoleBinding
apiVersion: rbac.authorization.k8s.io/v1
metadata:
name: configmap-viewer
namespace: openshift-pipelines
subjects:
- kind: Group
apiGroup: rbac.authorization.k8s.io
name: 'system:authenticated'
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
name: configmap-viewer
1 change: 1 addition & 0 deletions components/pipeline-service/base/rbac/openshift-pipelines/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: openshift-pipelines
resources:
- configmap-viewer.yaml
- pipeline-service-sre.yaml
- resolution-req-perms-exporter.yaml