RELEASE-2373: Drop noisy validation and pre-processing latency alerts - #1291
Draft
happybhati wants to merge 1 commit into
Draft
RELEASE-2373: Drop noisy validation and pre-processing latency alerts#1291happybhati wants to merge 1 commit into
happybhati wants to merge 1 commit into
Conversation
Remove early-dev latency alerts that flap and rarely indicate actionable controller failures. Keep controller availability alerts as the paging signal. Metrics remain available for dashboards. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft for review with Leandro / release team — please do not merge until agreed.
Proposal for RELEASE-2373: remove the two early-dev latency alerts that generate noise for SPRE without reflecting actionable release-service controller health, and keep controller availability alerts.
Removed
ReleaseServiceValidationDurationSeconds(90% under 5s)ReleaseServicePreProcessingDurationSeconds(PromQL used 60s; text said 10s)Kept
ReleaseServiceControllerManagerPodNotReadyReleaseServiceControllerManagerDown(slo: true/ critical)Why (prior guidance + Slack history)
highwas an interim step while RELEASE-2373 redesigns SLOs.release_validation_duration_seconds,release_pre_processing_duration_seconds) remain on the operator for Grafana — this PR only stops alerting on them.Follow-ups (not in this PR)
slo-document.yml(remove or revise validation / pre-processing / unused “finish <1h” entries).Test plan
make selective-check-and-test RULE_FILES="rhobs/alerting/data_plane/prometheus.release_service_alerts.yaml" TEST_CASE_FILES="test/promql/tests/data_plane/release_service_test.yaml"Made with Cursor