adding prometheus alert rule for pod high memory usage #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
@rh-gwinn please also implement unit tests for this. You can find several examples of unit tests in https://github.com/redhat-appstudio/o11y/tree/main/test/promql/tests/data_plane |
|
Also, if it helps there's a reference for these unit tests here: https://prometheus.io/docs/prometheus/latest/configuration/unit_testing_rules/ |
jdcasey
suggested changes
May 19, 2025
There was a problem hiding this comment.
I think most of these rules are missing thresholds, so I'm not sure if they will always go off, or never go off. I think there might be some duplication in the last 3 alerts in the file, too. And in a couple of cases it looks like the description / summary is wrong or incomplete.
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
rhobs/alerting/data_plane/prometheus.high_memory_usage_alert.yaml
Outdated
Show resolved
Hide resolved
indent line 40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prometheus / grafana alert setting