feat(PVO11Y-4761): Add Kanary signal exporter #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaisalAl-Rayes
force-pushed
the
kanary-signal-exporter
branch
from
d3779d6 to
6a403f0
Compare
|
Depends on #576 |
FaisalAl-Rayes
force-pushed
the
kanary-signal-exporter
branch
3 times, most recently
from
0afa481 to
27b8e81
Compare
|
/retest |
FaisalAl-Rayes
requested review from
raks-tt,
martysp21 and
pacho-rh
and removed request for
raks-tt,
martysp21 and
pacho-rh
martysp21
reviewed
May 27, 2025
| if err != nil { | ||
| log.Fatalf("FATAL: Error connecting to the database using DSN from %s: %v", dbURLEnvVar, err) | ||
| } | ||
| defer db.Close() |
There was a problem hiding this comment.
Would move the defer Close right after opening, so the open and error logic are together.
There was a problem hiding this comment.
Good point, moving it now
There was a problem hiding this comment.
The defer is at multiple places following the same patter: open, error, close
It would make sense to move the close in other places as well.
FaisalAl-Rayes
force-pushed
the
kanary-signal-exporter
branch
2 times, most recently
from
e697cd6 to
23ba13a
Compare
FaisalAl-Rayes
requested review from
martysp21
and removed request for
kubasikus,
pacho-rh,
raks-tt and
martysp21
FaisalAl-Rayes
force-pushed
the
kanary-signal-exporter
branch
2 times, most recently
from
d9cfc2f to
857f5c0
Compare
This commit introduces a new exporter to fetch Kanary signal values from a database and expose them as Prometheus metrics. Includes: - Core exporter logic for PostgreSQL. - `kanary_signal` metric with `cluster` and `status` labels. - `kanary_interruption` metric with `cluster` and `reason` labels - Use PedanticRegistry to control exposed Prometheus metrics. This ensures only explicitly registered application metrics are exported. - Unit tests using sqlmock. - README.md Signed-off-by: Faisal Al-Rayes <[email protected]>
FaisalAl-Rayes
force-pushed
the
kanary-signal-exporter
branch
from
857f5c0 to
042b9e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new exporter to fetch Kanary signal values from a database and expose them as Prometheus metrics.
Includes:
kanary_signalmetric withclusterandstatuslabels.kanary_interruptionmetric withclusterandreasonlabels