Merge pull request #341 from otaviof/fix-release-action

RHTAPINST-186: GitHub Release Action vs. Container Image
redhat-appstudio · Dec 6, 2024 · bf1c201 · bf1c201
2 parents 183fde2 + bad68cc
commit bf1c201
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/.github/actions/buildah/action.yaml b/.github/actions/buildah/action.yaml
@@ -9,14 +9,14 @@ inputs:
   IMAGE_NAMESPACE:
     description: Makefile's IMAGE_NAMESPACE variable
     required: false
+    default: ${{ github.repository_owner }}
   IMAGE_REPO_USERNAME:
     description: Makefile's IMAGE_REPO_USERNAME variable
     required: false
     default: ${{ github.actor }}
   IMAGE_REPO_PASSWORD:
     description: Makefile's IMAGE_REPO_PASSWORD variable
-    required: false
-    default: ${{ secrets.GITHUB_TOKEN }}
+    required: true
   tags:
     description: Comma-separated list of tags to apply to the image
     required: false

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -16,10 +16,15 @@ jobs:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/go
 
-      - name: Container Image
-        uses: ./.github/actions/buildah
-        with:
-          tags: "latest,${{ github.ref }}"
+      #
+      # TODO(otaviof): In order to build this container image, we need Red Hat
+      #   container registry credentials.
+      #
+      # - name: Container Image
+      #   uses: ./.github/actions/buildah
+      #   with:
+      #     tags: "latest,${{ github.ref }}"
+      #     IMAGE_REPO_PASSWORD: ${{ secrets.GITHUB_TOKEN }}
 
       - name: GitHub Release
         env:

diff --git a/Makefile b/Makefile
@@ -18,7 +18,6 @@ CGO_LDFLAGS ?=
 GITHUB_REF_NAME ?= ${GITHUB_REF_NAME:-}
 GITHUB_TOKEN ?= ${GITHUB_TOKEN:-}
 
-
 # Container registry credentials.
 IMAGE_REPO_USERNAME ?=
 IMAGE_REPO_PASSWORD ?=