Skip to content

[WIP] ESLint async rules #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jsmid1
Copy link
Collaborator

@jsmid1 jsmid1 commented Mar 25, 2025

This PR adds ESLint rules for async functions and applies them.

@jsmid1 jsmid1 force-pushed the No_floating_promises branch from f3c525a to 38b2683 Compare April 7, 2025 14:14
@jsmid1 jsmid1 force-pushed the No_floating_promises branch from 38b2683 to b643e9e Compare April 7, 2025 14:32
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
15.6% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@jsmid1
Copy link
Collaborator Author

jsmid1 commented Apr 7, 2025

/retest

@jsmid1 jsmid1 changed the title ESLint async rules [WIP] ESLint async rules Apr 7, 2025
@konflux-ci-qe-bot
Copy link
Collaborator

@jsmid1: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
e2e-4.17-rn62z Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/rhtap-team/rhtap-cli:e2e-4.17-rn62z

Test results analysis

<not enabled>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants