Improve Windows node workload for containerd and UPI deployments #9683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to ocp4_workload_windows_node: - Extract security groups and subnet from existing worker MachineSet instead of using hardcoded filters This fixes deployment failures in UPI CloudFormation environments where the default naming doesn't match - Add Windows node readiness check before proceeding with subsequent tasks - Allow node replacement by deleting existing image pull job if present - Replace docker commands with crictl for containerd runtime compatibility Installs and configures crictl on Windows nodes to align with current OpenShift container runtime - Update NetCandyStore helm chart from v1.0.1 to v1.0.2 Removes DeploymentConfig deprecation warnings These changes resolve deployment issues and modernize the Windows node workload for current OpenShift versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the
ocp4_workload_windows_nodeworkload to support containerd runtime and UPI CloudFormation deployments.Changes
MachineSet Configuration
cluster-id-worker-sg) doesn't existContainer Runtime
Reliability Improvements
NetCandyStore Update
Testing
These changes have been tested and resolve deployment issues in UPI environments while maintaining compatibility with IPI deployments.
Files Changed
ansible/roles_ocp_workloads/ocp4_workload_windows_node/tasks/workload.ymlansible/roles_ocp_workloads/ocp4_workload_windows_node/templates/windows-ms.j2ansible/roles_ocp_workloads/ocp4_workload_windows_node/templates/job-image-pull.j2ansible/roles_ocp_workloads/ocp4_workload_windows_node/files/netcandystore-1.0.2.tgz(new)ansible/roles_ocp_workloads/ocp4_workload_windows_node/files/netcandystore-1.0.1.tgz(removed)