Fix ee_builder ansible.cfg templating error when ee_aap_version is a string#267
Open
dancorrigan1 wants to merge 2 commits into
Open
Fix ee_builder ansible.cfg templating error when ee_aap_version is a string#267dancorrigan1 wants to merge 2 commits into
dancorrigan1 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a templating failure in the
ee_builderrole whenee_aap_versionissupplied as a string. The
ansible.cfg.j2template selected the galaxy APIendpoints with a numeric comparison (
{% if ee_aap_version >= 2.5 %}), whichraises
'>=' not supported between instances of 'str' and 'float'whenever thevalue comes through as a string (e.g.
"2.4") rather than the bare float indefaults/main.yml.How should this be tested?
This PR replaces the numeric comparison with Ansible's
versiontest: