Improve error messages by checking detail and error keys#1305
Draft
djdanielsson wants to merge 3 commits intoredhat-cop:develfrom
Draft
Improve error messages by checking detail and error keys#1305djdanielsson wants to merge 3 commits intoredhat-cop:develfrom
djdanielsson wants to merge 3 commits intoredhat-cop:develfrom
Conversation
Tompage1994
approved these changes
Mar 18, 2026
The error handler only checked the msg key from async task results. Some modules (ansible.controller.role, ansible.hub.ah_collection) put their error information in the detail or error keys instead, resulting in unhelpful messages like "Module failed: 'detail'" or "Unknown Error". Add fallback lookups for the detail and error keys before falling back to the generic Unknown Error message. Fixes redhat-cop#1267 Fixes redhat-cop#1255 Made-with: Cursor
Made-with: Cursor
| vars: | ||
| __new_error: | ||
| ERROR_MESSAGE: "{{ __cas_job_async_result['msg'] | default('UNKNOWN ERROR') }}" | ||
| ERROR_MESSAGE: "{{ __cas_job_async_result['msg'] | default(__cas_job_async_result['detail'] | default(__cas_job_async_result['error'] | default('UNKNOWN ERROR'))) }}" |
Collaborator
There was a problem hiding this comment.
Do we want to put all 3 if they are defined? instead of defaulting to one?
Collaborator
Author
|
I am wondering if #1299 would over ride this anyways... maybe we close this and I test out the other PR and merge that if it works |
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
djdanielsson
temporarily deployed
to
requires-approval
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error handler only checked the msg key from async task results. Some modules (ansible.controller.role, ansible.hub.ah_collection) put their error information in the detail or error keys instead, resulting in unhelpful messages like "Module failed: 'detail'" or "Unknown Error".
Add fallback lookups for the detail and error keys before falling back to the generic Unknown Error message.
Fixes #1267
Fixes #1255
Made-with: Cursor