Fix: "controller_hosts" role ignores "enabled: false" and enables host unconditionally.#1346
Open
nikhjain14 wants to merge 1 commit intoredhat-cop:develfrom
Open
Fix: "controller_hosts" role ignores "enabled: false" and enables host unconditionally.#1346nikhjain14 wants to merge 1 commit intoredhat-cop:develfrom
nikhjain14 wants to merge 1 commit intoredhat-cop:develfrom
Conversation
…t unconditionally. When "enabled: false" is set for a host in "controller_hosts", the host is still being added to the inventory in an enabled state. The value of enabled is being overridden or misinterpreted during task execution in "roles/controller_hosts/tasks/main.yml". Expected: Host should be added to the controller with "enabled: false". Actual: Host is added, but always set to "enabled: true" regardless of input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
controller_hostsrole ignores theenabled: falseparameter and always adds the host in an enabled state to the Controller inventory.Issue Type
Problem
When defining a host with
enabled: falsein thecontroller_hostsvariable list, the host is successfully created in the controller inventory but is always enabled, ignoring the explicitly set value.Example configuration that triggers the bug:
Expected behavior:
Host
my-execution-nodeshould be added toDemo Inventorywith enabled set tofalse(disabled state).Actual behavior:
Host
my-execution-nodeis added toDemo Inventorywith enabled set totrueregardless of the value passed.Solution
Changed
default(omit, true)todefault(omit)in theenabledparameter definition. Removing the secondtrueargument ensures the filter only omits the parameter when it is truly undefined/not set, and correctly passesfalseto the module whenenabled: falseis explicitly specified bythe user.
Related Issue
Fixes #1345