Bmad epic 5#320
Merged
raffaelespazzoli merged 7 commits intoredhat-cop:mainfrom Apr 30, 2026
Merged
Conversation
Adds comprehensive story file for KubernetesSecretEngineConfig/Role integration tests (Tier 1: Kind cluster). GitHub, Azure, and Quay types classified as Tier 3: Skip per Epic 4 retrospective infrastructure rules. Updates sprint-status.yaml to mark Story 5.3 as ready-for-dev. Made-with: Cursor
…n tests Story 5.1: DatabaseSecretEngineConfig/Role integration tests (PostgreSQL). Story 5.2: RabbitMQSecretEngineConfig/Role integration tests (RabbitMQ in Kind). Made-with: Cursor
…etEngineRole (Story 5.1) Covers full CRUD lifecycle against real PostgreSQL in Kind: create mount, config with connection_details verification, role with TTL/statement verification, update with ObservedGeneration check, and delete with Vault cleanup for both IsDeletable=true types. Made-with: Cursor
…etEngineRole (Story 5.2) Deploy RabbitMQ via plain K8s manifests (official 3-management image), add Ginkgo integration tests covering full lifecycle: create, reconcile, update, and delete for both config and role CRs, including IsDeletable=false persistence verification and vhosts payload assertions. Adds deploy-rabbitmq Makefile target wired into the integration pipeline. Made-with: Cursor
Vault's Go API client deserializes JSON objects into map[string]interface{},
not raw JSON strings. Marshal vhosts back to JSON before substring checks.
Made-with: Cursor
…SecretEngineRole (Story 5.3) Full lifecycle integration tests covering config creation with JWT reference, role CRUD with ObservedGeneration tracking, Vault state verification, and cleanup. Includes decoder methods, test fixtures, and resolved review findings. Made-with: Cursor
Epic 5 (Secret Engine Integration Tests) delivered 3 stories covering 6 secret engine types in ~2 days with +4.0pp coverage growth (42.0% → 46.0%), zero regressions, and 8 code review findings. Retrospective captures key insights on infrastructure prep compounding, write-only Vault endpoints, and ObservedGeneration assertion quality. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Epic 5: Secret Engine Integration Tests