-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initialize DAP support #735
Conversation
@SCWells72 the DAP support should start working, please read https://github.com/redhat-developer/lsp4ij/blob/2b3b0ce556aa71f286beb770764726baa769f55a/docs/dap/user-defined-dap/vscode-js-debug.md to test debugging with JavaScript and VSCode JS Debug. |
2b3b0ce
to
4a05c00
Compare
@CppCXY I have started to implement a DAP support. I wonder if you could be interested with this DAP support to provide the capability to debug lua files by consuming a DAP lua debugger. My quick search about DAP lua debugger is https://github.com/mfussenegger/nvim-dap/wiki/Debug-Adapter-installation#local-lua-debugger-vscode |
I have implemented and maintained emmylua debugger myself, and it supports both DAP and debugging based on IntelliJ xdebugger. When I have time, I will try the intellij DAP api you implemented. |
Nice! Could yiu give me some links where you have implemented your DAP client ? |
Your link is about DAP lua server, but what about DAP client implemented in IntelliJ? |
https://github.com/EmmyLua/VSCode-EmmyLua/blob/master/src/debugger/base/EmmyDebugSession.ts |
I am sorry again. It seems this code is the DAP client written in ts used by vscode. My question is about the DAP client written in Java and Intellij XDebugSession. |
Maybe I didn't express myself clearly. We have implemented debugging methods separately: a DAP client based on ts and a debugging based on IntelliJ xdebugger, not IntelliJ's DAP. Additionally, the IntelliJ part was not implemented by me, so I am not very familiar with it. |
Ok understood, you don't use DAP debugging with Intellij. With my current PR you should consume your DAP server that you have written in vscode. |
4a05c00
to
6387467
Compare
@CppCXY if you can compile your DAP lua debugger written in ts in an one js file (ex: dapDebugServer.js) , you could after that just configure it without developing something like VSCode JSDebug DAP, in otherwise you could do like this: If it works, we could host your config in a template like I did for VSCode JS Debug DAP server. |
d3fcfa8
to
f6cc787
Compare
a010627
to
8e84240
Compare
f8f3d20
to
68a6719
Compare
b654a5a
to
253143a
Compare
Signed-off-by: azerr <[email protected]>
253143a
to
d1733cb
Compare
feat: initialize DAP support