azure windows sku filter g2 sku#493
Merged
Merged
Conversation
lilyLuLiu
force-pushed
the
windows-v2
branch
2 times, most recently
from
7952477 to
f1ee47c
Compare
adrianriobo
reviewed
May 26, 2025
| }) | ||
| return strings.Join(pp, " ") | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
I would suggest to move this function to the modules pkg, as then can be used by other actions ...
You can put the validation on the https://github.com/redhat-developer/mapt/blob/main/pkg/provider/azure/module/virtual-machine/virtual-machine.go as you are passing it as param...
But the call tocheck the images...I guess it would make sense here https://github.com/redhat-developer/mapt/blob/main/pkg/provider/azure/data/images.go
Contributor
Author
There was a problem hiding this comment.
moved the functions to the suggested location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #489