fix: azure spot metrics by region is causing rate limit issues invokung azure api #634
+76
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng azure api this commit will use a single query to get the information and the split it across each regions calculation. This is a similar behavior as we had before the spot module refactor and should fix the rate limit issues. Fixes redhat-developer#573. Signed-off-by: Adrian Riobo <[email protected]>
This commit removes the error in case it is not set, as it may is set or not, on Azure is not mandatory, also in case not set mapt will print anf Info message telling how to set it. Otherwise the change introduced redhat-developer@17f871c would break backwards compatibility. Signed-off-by: Adrian Riobo <[email protected]>
previously all prices were printed no matter the log level, this commit ensures those information is only printed if debug is enable Signed-off-by: Adrian Riobo <[email protected]>
|
@anjannath can you quick check on this as PD is complaining about it, I tested with Windows and it worked as expected also I added a fix for default location which was breaking backwards if no ENV was set |
|
Also if this goes in, I will release a new version for mapt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit will use a single query to get the information and the split it across each regions calculation. This is a similar behavior as we had before the spot module refactor and should fix the rate limit issues.
Fixes #573.