chore: upgrade tasks to node 20 #225
Conversation
lstocchi
force-pushed
the
migrateNode20
branch
8 times, most recently
from
1e59b91 to
008a13c
Compare
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '10.x' | ||
| node-version: '20.x' |
There was a problem hiding this comment.
Excuse my ignorance, I'm not really familiar with this repo and Github workflows.
But why the version is hard coded in here instead of "node-version: ${{ matrix.node }}" like on line 28?
If my question doesn't make sense, please feel free to ignore me :)
There was a problem hiding this comment.
There is no strong opinion to why a hard coded version is better than a matrix in this case and it could be changed. Obviously, in general cases, running many matrix tests is more expensive. In this case, the tests are minimal .... it just runs matrix on linux to identify some potential errors with a specific version of node (to see if some func has been deprecated/removed and the code break), and on win/Mac just targets the version which should be used at runtime.
I'm not working with azure devops anymore (I left this field 3+ years ago) so I'm not really updated about it but it seems they recommend node 20. This is why I changed it
There was a problem hiding this comment.
Ah makes sense, much appreciated!
|
This PR has been open for a bit. Is there is anything that others can do to push it along? I am interested helping move it forward, if possible. Thank you! |
|
@KChavez04 unfortunately i'm not responsible anymore for this project and i don't have bandwidth to work on it. BTW i'll try to find 1 hour on monday to complete it as it is very close to be released. Sorry for the trouble |
lstocchi
force-pushed
the
migrateNode20
branch
4 times, most recently
from
0a6389f to
2b55cf8
Compare
Signed-off-by: lstocchi <[email protected]>
|
Just tested and it does not work bc of an error with the node-fetch lib. |
3 participants
No description provided.